Bug 90563 – [chromium] Add a method didChangeFormState to WebViewClient.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oli Lan]

[chromium] Add a method didChangeFocusedFormNodeState to WebViewClient.

[Oli Lan]

Created attachment 150811 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 150811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150811&action=review

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:845
> +    if (node->focused() && m_webView->client())
> +        m_webView->client()->didChangeFocusedFormNodeState();

Should we pass |node| to the client, or does it not care?  Should we have a client callback that we call unconditionally and let the embedder test for node->focused() ?

[Oli Lan]

Comment on attachment 150811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150811&action=review

>> Source/WebKit/chromium/src/ChromeClientImpl.cpp:845
>> +        m_webView->client()->didChangeFocusedFormNodeState();
> 
> Should we pass |node| to the client, or does it not care?  Should we have a client callback that we call unconditionally and let the embedder test for node->focused() ?

For the current purposes of the Android port this is sufficient, but passing the node unconditionally and allowing the client to perform whatever logic is required makes sense. Happy to make this change.

[Adam Barth]

Yeah, let's do that. It will probably save us from having to add another callback later.

[Oli Lan]

Created attachment 150935 [details]
Patch

[Oli Lan]

OK, the new patch implements the above. As WebNode did not have a focused method, the patch also adds a focused method to WebNode to allow the new method to be used as discussed.

[Adam Barth]

Comment on attachment 150935 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 150935 [details]
Patch

Clearing flags on attachment: 150935

Committed r121904: <http://trac.webkit.org/changeset/121904>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.