Bug 90562 - [Qt] ShadowBlur does not use GraphicsContext internal brush properties
Summary: [Qt] ShadowBlur does not use GraphicsContext internal brush properties
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bruno Abinader (history only)
Keywords: Qt
Depends on:
Blocks: 90082
  Show dependency treegraph
Reported: 2012-07-04 09:05 PDT by Bruno Abinader (history only)
Modified: 2014-02-03 03:21 PST (History)
2 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2012-07-04 09:05:58 PDT
Currently GraphicsContext::fillRect(const FloatRect& rect) implementation uses ShadowBlur's beginShadowLayer/endShadowLayer functions to handle shadow drawing. These can get optimized by using drawRectShadow, however it seems that ShadowBlur's implementation is not taking in consideration Qt's current brush properties. This bug intends to implement full support of drawRectShadow() usage on fillRect function.
Comment 1 Allan Sandfeld Jensen 2013-03-09 05:53:34 PST
ShadowBlur will in drawShadowBuffer() set a new fillcolor which completely replaces the current brush with a new solid brush of that color. If part of the current brush properties are supposed to be preserved, maybe our implementation of setPlatformFillColor is reseting too much?
Comment 2 Allan Sandfeld Jensen 2013-03-11 04:05:16 PDT
I noticed this comment in GraphicsContextCG:  // Don't use ShadowBlur for canvas yet.

So perhaps tiled ShadowBlur is not yet ready for shadowsIgnoreTransforms, disabling it for canvas solves the regressions from bug #90082
Comment 3 Jocelyn Turcotte 2014-02-03 03:21:35 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.