RESOLVED INVALID90562
[Qt] ShadowBlur does not use GraphicsContext internal brush properties 
https://bugs.webkit.org/show_bug.cgi?id=90562
Summary [Qt] ShadowBlur does not use GraphicsContext internal brush properties
Bruno Abinader (history only)
Reported 2012-07-04 09:05:58 PDT
Currently GraphicsContext::fillRect(const FloatRect& rect) implementation uses ShadowBlur's beginShadowLayer/endShadowLayer functions to handle shadow drawing. These can get optimized by using drawRectShadow, however it seems that ShadowBlur's implementation is not taking in consideration Qt's current brush properties. This bug intends to implement full support of drawRectShadow() usage on fillRect function.
Attachments
Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-03-09 05:53:34 PST
ShadowBlur will in drawShadowBuffer() set a new fillcolor which completely replaces the current brush with a new solid brush of that color. If part of the current brush properties are supposed to be preserved, maybe our implementation of setPlatformFillColor is reseting too much?
Allan Sandfeld Jensen
Comment 2 2013-03-11 04:05:16 PDT
I noticed this comment in GraphicsContextCG: // Don't use ShadowBlur for canvas yet. So perhaps tiled ShadowBlur is not yet ready for shadowsIgnoreTransforms, disabling it for canvas solves the regressions from bug #90082
Jocelyn Turcotte
Comment 3 2014-02-03 03:21:35 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.