Bug 90561 – Text Autosizing: Add test framework and simple test.

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[John Mellor]

Text Autosizing: Add test framework and simple test.

[John Mellor]

Created attachment 150815 [details]
Patch

[John Mellor]

Please check that I've gotten the TestExpectations and Skipped files right - I think this is right but I may have gotten confused about the dependencies.

[Eric Seidel (no email)]

Comment on attachment 150815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150815&action=review

> Source/WebCore/page/Settings.cpp:143
> +#if HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP
> +    , m_textAutosizingWindowSizeOverride(320, 480)

It's unclear to me why the hack is needed.  I'm not sure what the best practice for turning on mobile-only flags are in Chromium, but presumably about: flags could work.  And then once its on, a <viewport> element would let you test it on your desktop w/o needing this compile time hack, no?

> Source/WebCore/page/Settings.cpp:423
> +void Settings::setTextAutosizingWindowSizeOverride(IntSize textAutosizingWindowSizeOverride)

I think we normally pass IntSize by const reference "const IntSize&", but I'm not sure.

[Eric Seidel (no email)]

Comment on attachment 150815 [details]
Patch

LGTM.  Consider changing the const ref.

[John Mellor]

Created attachment 150847 [details]
Patch

Passes IntSize by const reference.

[Kenneth Rohde Christiansen]

Comment on attachment 150847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150847&action=review

> Source/WebCore/page/Settings.cpp:144
> +#if HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP
> +    , m_textAutosizingWindowSizeOverride(320, 480)
>      , m_textAutosizingEnabled(true)

Is this needed as part of this patch if you call setTextAutosizingWindowSizeOverride anyway?

> Source/WebCore/rendering/TextAutosizer.cpp:-54
> -#ifdef HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP
> -    IntSize windowSize(320, 480);
> -#else

Ah it is because you had the code here before. Fine then

[WebKit Review Bot]

Comment on attachment 150847 [details]
Patch

Rejecting attachment 150847 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
form/qt/TestExpectations
Hunk #1 FAILED at 101.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/TestExpectations.rej
patching file LayoutTests/platform/win/Skipped
Hunk #1 succeeded at 1286 (offset -10 lines).
patching file LayoutTests/platform/wincairo/Skipped
patching file LayoutTests/platform/wk2/Skipped

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13138823

[John Mellor]

Created attachment 150910 [details]
Patch

Rebased TestExpectations

[Adam Barth]

Comment on attachment 150910 [details]
Patch

Forwarding kenneth's R+.

@johnme: In the future, if you're just resolving merge conflicts, you can fill out the reviewer field in the ChangeLog.  I think webkit-patch land-safely will do that for you.

[WebKit Review Bot]

Comment on attachment 150910 [details]
Patch

Clearing flags on attachment: 150910

Committed r121907: <http://trac.webkit.org/changeset/121907>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.