Because SegmentedString knows how to track the current line and column, a tokenizer does not need to keep track of the current line by itself.
Created attachment 150771 [details] Patch
Comment on attachment 150771 [details] Patch Attachment 150771 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13139491
Comment on attachment 150771 [details] Patch Attachment 150771 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13131774
Comment on attachment 150771 [details] Patch Attachment 150771 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13134749
Created attachment 150775 [details] Patch
Fix build break with ENABLE_VIDEO_TRACK guard.
Comment on attachment 150775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150775&action=review This looks great. > Source/WebCore/html/parser/HTMLDocumentParser.cpp:452 > + const SegmentedString& currentString = m_input.current(); > + return currentString.currentLine(); I would just combine these two lines to avoid having the temporary.
Committed r121858: <http://trac.webkit.org/changeset/121858>
(In reply to comment #7) > (From update of attachment 150775 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150775&action=review > > This looks great. > > > Source/WebCore/html/parser/HTMLDocumentParser.cpp:452 > > + const SegmentedString& currentString = m_input.current(); > > + return currentString.currentLine(); > > I would just combine these two lines to avoid having the temporary. Thanks. I combined the two lines and landed the patch.