Bug 90544 – Stop tracking line number in tokenizer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kwang Yul Seo]

Because SegmentedString knows how to track the current line and column, a tokenizer does not need to keep track of the current line by itself.

[Kwang Yul Seo]

Created attachment 150771 [details]
Patch

[WebKit Review Bot]

Comment on attachment 150771 [details]
Patch

Attachment 150771 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13139491

[Gyuyoung Kim]

Comment on attachment 150771 [details]
Patch

Attachment 150771 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13131774

[Gustavo Noronha (kov)]

Comment on attachment 150771 [details]
Patch

Attachment 150771 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13134749

[Kwang Yul Seo]

Created attachment 150775 [details]
Patch

[Kwang Yul Seo]

Fix build break with ENABLE_VIDEO_TRACK guard.

[Adam Barth]

Comment on attachment 150775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150775&action=review

This looks great.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:452
> +    const SegmentedString& currentString = m_input.current();
> +    return currentString.currentLine();

I would just combine these two lines to avoid having the temporary.

[Kwang Yul Seo]

Committed r121858: <http://trac.webkit.org/changeset/121858>

[Kwang Yul Seo]

(In reply to comment #7)
> (From update of attachment 150775 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150775&action=review
> 
> This looks great.
> 
> > Source/WebCore/html/parser/HTMLDocumentParser.cpp:452
> > +    const SegmentedString& currentString = m_input.current();
> > +    return currentString.currentLine();
> 
> I would just combine these two lines to avoid having the temporary.

Thanks. I combined the two lines and landed the patch.