Bug 90539 - The HTML5 formtarget/formaction/formenctyp/formmethod/formnovalidate attributes don't work in button tags with nested elements
Summary: The HTML5 formtarget/formaction/formenctyp/formmethod/formnovalidate attribut...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-04 03:48 PDT by Martí Congost
Modified: 2012-10-17 00:06 PDT (History)
6 users (show)

See Also:

Attachments
Test case for this issue. (971 bytes, text/html)
2012-07-04 03:48 PDT, Martí Congost 		no flags Details
Patch (5.62 KB, patch)
2012-10-16 22:06 PDT, Kunihiko Sakamoto 		no flags Details | Formatted Diff | Diff
Patch 2 (5.65 KB, patch)
2012-10-16 22:45 PDT, Kunihiko Sakamoto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martí Congost 2012-07-04 03:48:59 PDT 
Created attachment 150762 [details]
Test case for this issue.

When clicking a button with a 'formtarget' attribute, the value of the attribute is not honored if the target of the click event is an element nested within the button, instead the button itself.

I've attached a small test case for this issue, which I have reproduced on Chromium/Chrome on both Linux and Windows.
Comment 1 Kunihiko Sakamoto 2012-10-16 22:06:05 PDT 
Created attachment 169087 [details]
Patch
Comment 2 Kent Tamura 2012-10-16 22:25:50 PDT 
Comment on attachment 169087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169087&action=review

> LayoutTests/fast/forms/formaction-attribute.html:-16
> -var doneAction2 = false;

Why did you remove this?
You should mention a reason for such unclear changes in the ChangeLog entry.
Comment 3 Kunihiko Sakamoto 2012-10-16 22:45:21 PDT 
Created attachment 169092 [details]
Patch 2
Comment 4 Kunihiko Sakamoto 2012-10-16 22:46:46 PDT 
Comment on attachment 169087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169087&action=review

>> LayoutTests/fast/forms/formaction-attribute.html:-16
>> -var doneAction2 = false;
> 
> Why did you remove this?
> You should mention a reason for such unclear changes in the ChangeLog entry.

Because this variable is not used.
Updated the ChangeLog entry in Patch 2.
Comment 5 Kent Tamura 2012-10-16 23:45:24 PDT 
Comment on attachment 169092 [details]
Patch 2

ok
Comment 6 WebKit Review Bot 2012-10-17 00:06:45 PDT 
Comment on attachment 169092 [details]
Patch 2

Clearing flags on attachment: 169092

Committed r131555: <http://trac.webkit.org/changeset/131555>
Comment 7 WebKit Review Bot 2012-10-17 00:06:51 PDT 
All reviewed patches have been landed.  Closing bug.