WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
90535
Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90535
Summary
Record metrics to measure the usage of WebKitBlobBuilder to eventually deprec...
Kinuko Yasuda
Reported
2012-07-04 02:36:04 PDT
Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it (on the platforms where it is still exposed, i.e. chromium)
Attachments
Patch
(4.27 KB, patch)
2012-07-04 02:38 PDT
,
Kinuko Yasuda
eric
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1
2012-07-04 02:38:36 PDT
Created
attachment 150745
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-08-12 03:46:13 PDT
Comment on
attachment 150745
[details]
Patch OK.
Eric Seidel (no email)
Comment 3
2012-08-12 03:46:48 PDT
Comment on
attachment 150745
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=150745&action=review
> Source/WebCore/fileapi/WebKitBlobBuilder.h:49 > + BlobConstructionReasonMax,
This Max isn't needed. But I expect (hope?) that this code won't be aroudn very long anyway.
WebKit Review Bot
Comment 4
2012-08-12 03:48:18 PDT
Comment on
attachment 150745
[details]
Patch Rejecting
attachment 150745
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: k #1 succeeded at 138 (offset -1 lines). patching file Source/WebCore/fileapi/WebKitBlobBuilder.cpp Hunk #1 FAILED at 35. Hunk #2 succeeded at 158 with fuzz 1 (offset 17 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/fileapi/WebKitBlobBuilder.cpp.rej patching file Source/WebCore/fileapi/WebKitBlobBuilder.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output:
http://queues.webkit.org/results/13476764
Kinuko Yasuda
Comment 5
2012-08-12 21:18:05 PDT
Committed
r125386
: <
http://trac.webkit.org/changeset/125386
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug