nrwt: clean up exception handling and make sure we log some more failures
Created attachment 150683 [details]
Attachment 150683 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:415: deprecated form of raising exception [pep8/W602] 
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 150683 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=150683&action=review
> + # happenss (and log the appropriate messages).
> + driver = self._driver
> + self._driver = None
> + if driver:
> _log.debug("%s killing driver" % self._name)
> - self._driver.stop()
> - self._driver = None
> + driver.stop()
We don't need to worry about thread-safety, right? In that case, couldn't you just move the self._drive = None line to being right after the if statement? Then you wouldn't need the local variable. Not a big deal, just a little easier to read.
Committed r121816: <http://trac.webkit.org/changeset/121816>