Bug 90488 - Inspector tests are slow
Summary: Inspector tests are slow
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-03 12:05 PDT by Tony Chang
Modified: 2014-12-17 16:30 PST (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-07-03 12:05:01 PDT
This was noticed when we switched from test shell to DRT in chromium. There might be an unnecessary slowness in DRT (maybe we can cache the inspector?) or some other low hanging fruit.

All inspector tests are currently marked as slow in LayoutTests/platform/chromium/TestExpectations.
Comment 1 Alexandru Chiculita 2012-07-11 17:40:20 PDT
It's not slow, it's just not loading at all because it tries to load the devtools.html from the wrong place.

On my machine it tries the following url, but the inspector is not there. Copying it from src/out/Release/resources seems to fix the issue.

src/out/Release/DumpRenderTree.app/Contents/MacOS/resources/inspector/devtools.html
Comment 2 Tony Chang 2012-07-12 09:53:04 PDT
(In reply to comment #1)

> src/out/Release/DumpRenderTree.app/Contents/MacOS/resources/inspector/devtools.html

We don't currently run inspector tests on Chromium Mac.  Search for BUGCR89357 in TestExpectations.
Comment 3 Takashi Toyoshima 2012-08-05 22:19:03 PDT
FYI, database-structure.html starts to crash recently.
I filed another bug; https://bugs.webkit.org/show_bug.cgi?id=93225
Comment 4 Kenneth Russell 2012-08-20 11:25:13 PDT
Seeing http/tests/inspector/network-preflight-options.html start to time out on Windows Release as well. See:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Finspector%2Fnetwork-preflight-options.html
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/16909

Marking this test slow in Release mode in TestExpectations as well.
Comment 5 Kenneth Russell 2012-08-20 11:56:23 PDT
Committed r126049: <http://trac.webkit.org/changeset/126049>
Comment 6 Adam Klein 2012-12-10 10:01:51 PST
Another single test that always times out in Win/Mac debug: inspector/styles/styles-computed-trace.html.

http://trac.webkit.org/changeset/137156 tried to remove the expectations entirely, and succeeded on Linux (test now passes in about 30s on Linux debug), but it still always times out on Win/Mac, so I re-added those expectations in http://trac.webkit.org/changeset/137174.
Comment 7 Dominic Cooney 2013-01-15 18:39:58 PST
Also inspector/extensions/extensions-reload.html is flakily slow on Win Release:

<http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fextensions%2Fextensions-reload.html>

Added expectations in r139820.
Comment 8 Dominic Cooney 2013-01-15 18:47:30 PST
Retitling this because a couple of Win release tests are discussed here.