Bug 90474 - IndexedDB: A null or undefined storeNames argument to IDBDatabase::transaction() should be coerced to string
Summary: IndexedDB: A null or undefined storeNames argument to IDBDatabase::transactio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on: 84217
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-03 10:35 PDT by Joshua Bell
Modified: 2012-07-09 17:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.50 KB, patch)
2012-07-03 10:36 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (7.20 KB, patch)
2012-07-09 10:12 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch for landing (7.64 KB, patch)
2012-07-09 16:26 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-07-03 10:35:34 PDT
IndexedDB: A null or undefined storeNames argument to IDBDatabase::transaction() should be coerced to string
Comment 1 Joshua Bell 2012-07-03 10:36:00 PDT
Created attachment 150640 [details]
Patch
Comment 2 Joshua Bell 2012-07-03 18:42:17 PDT
Comment on attachment 150640 [details]
Patch

Whoops, got uploaded with no changelog.
Comment 3 Joshua Bell 2012-07-09 10:12:44 PDT
Created attachment 151266 [details]
Patch
Comment 4 Joshua Bell 2012-07-09 10:15:33 PDT
alecflett@, dgrogan@ - please take a look.
Comment 5 David Grogan 2012-07-09 14:03:00 PDT
Comment on attachment 151266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151266&action=review

LGTM

> LayoutTests/storage/indexeddb/resources/transaction-basics.js:289
> +    debug("Test that null and undefined are treated as strings");

Could you add a couple of evalAndExpectException lines in here for transaction = db.transaction(null/undefined)?
Comment 6 Joshua Bell 2012-07-09 16:26:30 PDT
Created attachment 151348 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-07-09 17:48:26 PDT
Comment on attachment 151348 [details]
Patch for landing

Clearing flags on attachment: 151348

Committed r122173: <http://trac.webkit.org/changeset/122173>
Comment 8 WebKit Review Bot 2012-07-09 17:48:31 PDT
All reviewed patches have been landed.  Closing bug.