Inspector may take significant amount of memory when traversing DOM structure. Take it into account and report under inspector memory.
Created attachment 150596 [details] Patch
Comment on attachment 150596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150596&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:446 > + return sizeof(ContainerType) + container.capacity() * sizeof(typename ContainerType::ValueType); Please use the code for calculating container size from MemoryInstrumentation to avoid duplication, r- for this. > Source/WebCore/inspector/InspectorMemoryAgent.cpp:614 > + inspectorData.countSize(ScriptProfiler::profilerSnapshotsSize()); What about reporting profile and visited nodes map sizes as separate children of InspectorData block?
Created attachment 151091 [details] Patch
Comment on attachment 150596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150596&action=review >> Source/WebCore/inspector/InspectorMemoryAgent.cpp:446 >> + return sizeof(ContainerType) + container.capacity() * sizeof(typename ContainerType::ValueType); > > Please use the code for calculating container size from MemoryInstrumentation to avoid duplication, r- for this. done >> Source/WebCore/inspector/InspectorMemoryAgent.cpp:614 >> + inspectorData.countSize(ScriptProfiler::profilerSnapshotsSize()); > > What about reporting profile and visited nodes map sizes as separate children of InspectorData block? done
Comment on attachment 151091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151091&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:646 > + children->addItem(domTreeInfo(m_page, visitedObjects, &inspectorData)); // TODO: collect for all pages? // FIXME:
Comment on attachment 151091 [details] Patch Rejecting attachment 151091 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/MemoryInstrumentation.h patching file Source/WebCore/inspector/InspectorMemoryAgent.cpp Hunk #7 succeeded at 575 with fuzz 1. Hunk #8 FAILED at 633. 1 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/inspector/InspectorMemoryAgent.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13204004
Created attachment 151476 [details] Patch
Comment on attachment 151091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151091&action=review also done rebaselining >> Source/WebCore/inspector/InspectorMemoryAgent.cpp:646 >> + children->addItem(domTreeInfo(m_page, visitedObjects, &inspectorData)); // TODO: collect for all pages? > > // FIXME: done
Comment on attachment 151476 [details] Patch Clearing flags on attachment: 151476 Committed r122243: <http://trac.webkit.org/changeset/122243>
All reviewed patches have been landed. Closing bug.