Bug 90447 - Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
Summary: Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-03 04:33 PDT by Dongseong Hwang
Modified: 2012-07-04 23:54 PDT (History)
4 users (show)

See Also:


Attachments
patch (2.32 KB, patch)
2012-07-03 04:34 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-07-03 04:33:00 PDT
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.

Other sub-Image classes explicitly specify virtual on the destructors.

> grep "~.*Image(" `find -name "*.h"`
./graphics/BitmapImage.h:    ~BitmapImage();
./graphics/qt/StillImageQt.h:        ~StillImage();
./graphics/chromium/LayerTextureSubImage.h:    ~LayerTextureSubImage();  <- not implement Image
./graphics/GeneratorGeneratedImage.h:    virtual ~GeneratorGeneratedImage()
./graphics/Image.h:    virtual ~Image();
./graphics/cg/PDFDocumentImage.h:        virtual ~PDFDocumentImage();
Comment 1 Dongseong Hwang 2012-07-03 04:34:50 PDT
Created attachment 150581 [details]
patch
Comment 2 WebKit Review Bot 2012-07-04 23:54:16 PDT
Comment on attachment 150581 [details]
patch

Clearing flags on attachment: 150581

Committed r121884: <http://trac.webkit.org/changeset/121884>
Comment 3 WebKit Review Bot 2012-07-04 23:54:20 PDT
All reviewed patches have been landed.  Closing bug.