Bug 90444 – Update unit test after r121724

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/121724 broke the following unittest:


FAILURE: webkitpy.tool.servers.gardeningserver_unittest.GardeningServerTest.test_rebaseline_new_port
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 205, in test_rebaseline_new_port
    self._post_to_path("/rebaselineall", body='{"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}', expected_stderr=expected_stderr, expected_stdout=expected_stdout)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 178, in _post_to_path
    OutputCapture().assert_outputs(self, handler.do_POST, expected_stderr=expected_stderr, expected_stdout=expected_stdout)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 94, in assert_outputs
    testcase.assertEqual(stderr_string, expected_stderr)
AssertionError: 'MOCK run_command: [\'echo\', \'rebaseline-json\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n' != 'MOCK run_command: [\'echo\', \'rebaseline-all\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n'

[Peter Gal]

(In reply to comment #0)
> http://trac.webkit.org/changeset/121724 broke the following unittest:
> 

It seems the testcase wasn't updated after the renaming of the command.

[Ádám Kallai]

Created attachment 150580 [details]
proposed patch

I have updated the unit test. Do you think the changelog is correct now?

[Csaba Osztrogonác]

Comment on attachment 150580 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150580&action=review

LGTM, r=me with a little changelog fix.

> Tools/ChangeLog:3
> +        Update unit test after r121724.

Could you include the URL of this bug?

[Ádám Kallai]

Created attachment 150582 [details]
proposed fix

I fixed it.

[Csaba Osztrogonác]

Comment on attachment 150582 [details]
proposed fix

r=me

[WebKit Review Bot]

Comment on attachment 150582 [details]
proposed fix

Clearing flags on attachment: 150582

Committed r121759: <http://trac.webkit.org/changeset/121759>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ojan Vafai]

Thanks for fixing this!