Bug 90444 - Update unit test after r121724
Summary: Update unit test after r121724
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 90413
  Show dependency treegraph
Reported: 2012-07-03 04:09 PDT by Csaba Osztrogonác
Modified: 2012-07-03 10:21 PDT (History)
7 users (show)

See Also:

proposed patch (1.71 KB, patch)
2012-07-03 04:32 PDT, Ádám Kallai
ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
proposed fix (1.76 KB, patch)
2012-07-03 04:40 PDT, Ádám Kallai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-07-03 04:09:12 PDT
http://trac.webkit.org/changeset/121724 broke the following unittest:

FAILURE: webkitpy.tool.servers.gardeningserver_unittest.GardeningServerTest.test_rebaseline_new_port
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 205, in test_rebaseline_new_port
    self._post_to_path("/rebaselineall", body='{"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}', expected_stderr=expected_stderr, expected_stdout=expected_stdout)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 178, in _post_to_path
    OutputCapture().assert_outputs(self, handler.do_POST, expected_stderr=expected_stderr, expected_stdout=expected_stdout)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 94, in assert_outputs
    testcase.assertEqual(stderr_string, expected_stderr)
AssertionError: 'MOCK run_command: [\'echo\', \'rebaseline-json\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n' != 'MOCK run_command: [\'echo\', \'rebaseline-all\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n'
Comment 1 Peter Gal 2012-07-03 04:21:18 PDT
(In reply to comment #0)
> http://trac.webkit.org/changeset/121724 broke the following unittest:

It seems the testcase wasn't updated after the renaming of the command.
Comment 2 Ádám Kallai 2012-07-03 04:32:24 PDT
Created attachment 150580 [details]
proposed patch

I have updated the unit test. Do you think the changelog is correct now?
Comment 3 Csaba Osztrogonác 2012-07-03 04:34:40 PDT
Comment on attachment 150580 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150580&action=review

LGTM, r=me with a little changelog fix.

> Tools/ChangeLog:3
> +        Update unit test after r121724.

Could you include the URL of this bug?
Comment 4 Ádám Kallai 2012-07-03 04:40:14 PDT
Created attachment 150582 [details]
proposed fix

I fixed it.
Comment 5 Csaba Osztrogonác 2012-07-03 04:44:04 PDT
Comment on attachment 150582 [details]
proposed fix

Comment 6 WebKit Review Bot 2012-07-03 05:38:41 PDT
Comment on attachment 150582 [details]
proposed fix

Clearing flags on attachment: 150582

Committed r121759: <http://trac.webkit.org/changeset/121759>
Comment 7 WebKit Review Bot 2012-07-03 05:38:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ojan Vafai 2012-07-03 10:21:48 PDT
Thanks for fixing this!