Bug 90429 - [BlackBerry] Enable microdata support for BlackBerry
Summary: [BlackBerry] Enable microdata support for BlackBerry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-02 21:04 PDT by George Staikos
Modified: 2012-07-03 09:34 PDT (History)
3 users (show)

See Also:


Attachments
Patch - enable microdata support (2.52 KB, patch)
2012-07-02 21:08 PDT, George Staikos
rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Updated after collision (2.53 KB, patch)
2012-07-03 07:58 PDT, George Staikos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2012-07-02 21:04:24 PDT
Simply enable the microdata support for the port.
Comment 1 George Staikos 2012-07-02 21:08:37 PDT
Created attachment 150527 [details]
Patch - enable microdata support
Comment 2 Rob Buis 2012-07-03 07:07:00 PDT
Comment on attachment 150527 [details]
Patch - enable microdata support

LGTM.
Comment 3 WebKit Review Bot 2012-07-03 07:34:59 PDT
Comment on attachment 150527 [details]
Patch - enable microdata support

Rejecting attachment 150527 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ile ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/cmake/OptionsBlackBerry.cmake
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitperl/FeatureList.pm
Hunk #1 FAILED at 292.
1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/FeatureList.pm.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13124520
Comment 4 George Staikos 2012-07-03 07:58:43 PDT
Created attachment 150609 [details]
Updated after collision
Comment 5 WebKit Review Bot 2012-07-03 09:34:23 PDT
Comment on attachment 150609 [details]
Updated after collision

Clearing flags on attachment: 150609

Committed r121779: <http://trac.webkit.org/changeset/121779>
Comment 6 WebKit Review Bot 2012-07-03 09:34:28 PDT
All reviewed patches have been landed.  Closing bug.