Bug 90409 – nrwt: make the worker class stand alone with a cleaner interface

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt: make the worker class stand alone with a cleaner interface

[Dirk Pranke]

Created attachment 150491 [details]
Patch

[Ojan Vafai]

Comment on attachment 150491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150491&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:64
>      def safe_init(self):

I know you're not defining this method now, but this name doesn't match what it does to me. I would think "safe" would mean we can call it whenever we want, but it actually means we can only call it if the object doesn't need to be pickled. Should we just call this init_unpicklable_state? It's kinda verbose, but it's much more clear what it's doing.

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 150491 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150491&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:64
> >      def safe_init(self):
> 
> I know you're not defining this method now, but this name doesn't match what it does to me. I would think "safe" would mean we can call it whenever we want, but it actually means we can only call it if the object doesn't need to be pickled. Should we just call this init_unpicklable_state? It's kinda verbose, but it's much more clear what it's doing.

It is a crappy name. In a later patch it gets renamed to "start" (and cleanup to "stop"), which I think is actually a clearer indication of its use.

[Dirk Pranke]

Committed r121809: <http://trac.webkit.org/changeset/121809>