Bug 90407 - DFG::ArgumentsSimplificationPhase should assert that the PhantomArguments nodes it creates are not shouldGenerate()
Summary: DFG::ArgumentsSimplificationPhase should assert that the PhantomArguments nod...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2012-07-02 15:33 PDT by Filip Pizlo
Modified: 2012-07-02 17:10 PDT (History)
0 users

See Also:

the patch (2.86 KB, patch)
2012-07-02 15:35 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-07-02 15:33:52 PDT
We already assert this in later phases.  But asserting sooner will make tracking bugs easier, not to mention that it makes the phase more self-documenting.
Comment 1 Filip Pizlo 2012-07-02 15:35:21 PDT
Created attachment 150484 [details]
the patch

Already reviewed in person by Mark.  Putting up for EWS while I run my own tests.
Comment 2 Filip Pizlo 2012-07-02 17:10:42 PDT
Landed in http://trac.webkit.org/changeset/121712