Bug 90379 – [MICRODATA] Build failure in html/HTMLPropertiesCollection.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Turning on the MICRODATA flag causes the following build failure:

In file included from /home/chris/Devel/WebKit/Source/WebCore/dom/NodeRareData.h:39:0,
                 from /home/chris/Devel/WebKit/Source/WebCore/dom/ClassNodeList.cpp:34:
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h: In member function ‘void WebCore::HTMLPropertiesCollection::<anonymous struct>::updatePropertyCache(WebCore::Element*, const WTF::AtomicString&)’:
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h:91:17: error: ‘static void WebCore::HTMLCollectionCacheBase::append(WebCore::HTMLCollectionCacheBase::NodeCacheMap&, const WTF::AtomicString&, WebCore::Element*)’ is private
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLPropertiesCollection.h:128:17: error: within this context
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h:91:17: error: ‘static void WebCore::HTMLCollectionCacheBase::append(WebCore::HTMLCollectionCacheBase::NodeCacheMap&, const WTF::AtomicString&, WebCore::Element*)’ is private
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLPropertiesCollection.h:128:60: error: within this context
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/dom/ClassNodeList.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2

[Chris Dumez]

Created attachment 150408 [details]
Patch

[Arko Saha]

Changes looks good to me but I am not a reviewer.

[WebKit Review Bot]

Comment on attachment 150408 [details]
Patch

Clearing flags on attachment: 150408

Committed r121689: <http://trac.webkit.org/changeset/121689>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.