Bug 90379 - [MICRODATA] Build failure in html/HTMLPropertiesCollection.h
Summary: [MICRODATA] Build failure in html/HTMLPropertiesCollection.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 90377
  Show dependency treegraph
 
Reported: 2012-07-02 05:51 PDT by Chris Dumez
Modified: 2012-07-02 09:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2012-07-02 06:02 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-02 05:51:01 PDT
Turning on the MICRODATA flag causes the following build failure:

In file included from /home/chris/Devel/WebKit/Source/WebCore/dom/NodeRareData.h:39:0,
                 from /home/chris/Devel/WebKit/Source/WebCore/dom/ClassNodeList.cpp:34:
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h: In member function ‘void WebCore::HTMLPropertiesCollection::<anonymous struct>::updatePropertyCache(WebCore::Element*, const WTF::AtomicString&)’:
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h:91:17: error: ‘static void WebCore::HTMLCollectionCacheBase::append(WebCore::HTMLCollectionCacheBase::NodeCacheMap&, const WTF::AtomicString&, WebCore::Element*)’ is private
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLPropertiesCollection.h:128:17: error: within this context
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h:91:17: error: ‘static void WebCore::HTMLCollectionCacheBase::append(WebCore::HTMLCollectionCacheBase::NodeCacheMap&, const WTF::AtomicString&, WebCore::Element*)’ is private
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLPropertiesCollection.h:128:60: error: within this context
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/dom/ClassNodeList.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
Comment 1 Chris Dumez 2012-07-02 06:02:55 PDT
Created attachment 150408 [details]
Patch
Comment 2 Arko Saha 2012-07-02 06:47:44 PDT
Changes looks good to me but I am not a reviewer.
Comment 3 WebKit Review Bot 2012-07-02 09:59:32 PDT
Comment on attachment 150408 [details]
Patch

Clearing flags on attachment: 150408

Committed r121689: <http://trac.webkit.org/changeset/121689>
Comment 4 WebKit Review Bot 2012-07-02 09:59:36 PDT
All reviewed patches have been landed.  Closing bug.