Bug 90374 - [EFL] Move jhbuild dependencies based on SVN to tarballs
Summary: [EFL] Move jhbuild dependencies based on SVN to tarballs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-02 05:32 PDT by Thiago Marcos P. Santos
Modified: 2012-08-20 17:32 PDT (History)
9 users (show)

See Also:


Attachments
Patch (7.79 KB, patch)
2012-08-20 04:22 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff
Patch (7.06 KB, patch)
2012-08-20 15:20 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-07-02 05:32:08 PDT
The bots are getting too many timeouts when connecting to EFL SVN repository. If we move to Git, the revision check is done offline if nothing changes.
Comment 1 Thiago Marcos P. Santos 2012-07-02 05:33:59 PDT
I think this is the closest we have to a official EFL Git mirror:
http://git.enlightenment.fr/


Enlightenment links to it:
http://www.enlightenment.org/p.php?p=contribute
Comment 2 Thiago Marcos P. Santos 2012-08-20 04:22:04 PDT
Created attachment 159391 [details]
Patch
Comment 3 Thiago Marcos P. Santos 2012-08-20 04:25:28 PDT
After applying this patch, update-webkitefl takes less than 1 sec on my machine after the first run.
Comment 4 Thiago Marcos P. Santos 2012-08-20 04:26:33 PDT
Gyuyoung, Raphael, and others. Could you please give your opinions and if possible try a clean build with this patch?

Thanks!
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-08-20 14:09:41 PDT
Comment on attachment 159391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159391&action=review

Looks fine to me -- I had some trouble in the past with these gitweb/cgit servers generating tarballs with different checksums each time they were fetched, but it looks like this doesn't happen here. Can you please remove the harfbuzz changes before committing?

> Tools/efl/jhbuild.modules:155
> - <autotools id="harfbuzz" autogen-sh="configure">
> -   <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2"
> -           checkoutdir="harfbuzz-0.9.2"
> -           repo="freedesktop.org"
> -           hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558"
> -           md5sum="f1c1a2793b44b4d6613f58cc92caa366">
> -   </branch>
> - </autotools>
> +  <autotools id="harfbuzz" autogen-sh="configure">
> +    <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2"
> +            checkoutdir="harfbuzz-0.9.2"
> +            repo="freedesktop.org"
> +            hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558"
> +            md5sum="f1c1a2793b44b4d6613f58cc92caa366">
> +    </branch>
> +  </autotools>

Looks unrelated.
Comment 6 Thiago Marcos P. Santos 2012-08-20 15:13:21 PDT
(In reply to comment #5)
> (From update of attachment 159391 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159391&action=review
> 
> Looks fine to me -- I had some trouble in the past with these gitweb/cgit servers generating tarballs with different checksums each time they were fetched, but it looks like this doesn't happen here. Can you please remove the harfbuzz changes before committing?
> 
> > Tools/efl/jhbuild.modules:155
> > - <autotools id="harfbuzz" autogen-sh="configure">
> > -   <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2"
> > -           checkoutdir="harfbuzz-0.9.2"
> > -           repo="freedesktop.org"
> > -           hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558"
> > -           md5sum="f1c1a2793b44b4d6613f58cc92caa366">
> > -   </branch>
> > - </autotools>
> > +  <autotools id="harfbuzz" autogen-sh="configure">
> > +    <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2"
> > +            checkoutdir="harfbuzz-0.9.2"
> > +            repo="freedesktop.org"
> > +            hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558"
> > +            md5sum="f1c1a2793b44b4d6613f58cc92caa366">
> > +    </branch>
> > +  </autotools>
> 
> Looks unrelated.

This is a known issue [1]. gzip stores the timestamp by default. That's why I'm taking the tar.bz2, that can produce stable snapshots. Gonna remove this indentation fix, should be done in another patch.

[1] http://git.661346.n2.nabble.com/PATCH-supply-n-to-gzip-to-produce-identical-tarballs-td6258329.html
Comment 7 Thiago Marcos P. Santos 2012-08-20 15:20:12 PDT
Created attachment 159533 [details]
Patch
Comment 8 WebKit Review Bot 2012-08-20 17:32:24 PDT
Comment on attachment 159533 [details]
Patch

Clearing flags on attachment: 159533

Committed r126104: <http://trac.webkit.org/changeset/126104>
Comment 9 WebKit Review Bot 2012-08-20 17:32:29 PDT
All reviewed patches have been landed.  Closing bug.