Bug 90330 - Add a cold-boot.sh script for the EWS
Summary: Add a cold-boot.sh script for the EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-29 21:27 PDT by Adam Barth
Modified: 2012-07-08 20:47 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.34 KB, patch)
2012-06-29 21:28 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2012-06-29 21:35 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-06-29 21:27:16 PDT
Add a cold-boot.sh script for the EWS
Comment 1 Adam Barth 2012-06-29 21:28:52 PDT
Created attachment 150301 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-29 21:34:12 PDT
Attachment 150301 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/EWSTools/cold-bo..." exit_code: 1
Tools/EWSTools/cold-boot.sh:62:  Line contains tab character.  [whitespace/tab] [5]
Tools/EWSTools/cold-boot.sh:63:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2012-06-29 21:35:12 PDT
Created attachment 150302 [details]
Patch
Comment 4 WebKit Review Bot 2012-06-29 21:37:46 PDT
Attachment 150302 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/EWSTools/cold-bo..." exit_code: 1
Tools/EWSTools/cold-boot.sh:64:  Line contains tab character.  [whitespace/tab] [5]
Tools/EWSTools/cold-boot.sh:65:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Adam Barth 2012-06-29 21:40:51 PDT
The tabs are needed for the config file format.
Comment 6 Adam Barth 2012-06-29 22:00:11 PDT
Committed r121621: <http://trac.webkit.org/changeset/121621>
Comment 7 Laszlo Gombos 2012-07-08 20:03:44 PDT
Comment on attachment 150302 [details]
Patch

Marking the patch obsolete to take it out from the review queue.
Comment 8 Adam Barth 2012-07-08 20:47:24 PDT
Thanks.  Sorry for the noise.