Bug 90322 - HTMLCollection's caches should be owned by either ElementRareData or Document
Summary: HTMLCollection's caches should be owned by either ElementRareData or Document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 89919
  Show dependency treegraph
 
Reported: 2012-06-29 16:02 PDT by Ryosuke Niwa
Modified: 2012-06-29 16:56 PDT (History)
8 users (show)

See Also:


Attachments
Cleanup (23.79 KB, patch)
2012-06-29 16:11 PDT, Ryosuke Niwa
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-06-29 16:02:58 PDT
Right now, multiple Element subclasses such as HTMLFormElement and HTMLSelectElement have their own OwnPtr of HTMLCollection. Since ElementRareData already has a cache entry for each collection type, we should be using that instead.
Comment 1 Ryosuke Niwa 2012-06-29 16:11:57 PDT
Created attachment 150268 [details]
Cleanup
Comment 2 Ryosuke Niwa 2012-06-29 16:56:50 PDT
Committed r121603: <http://trac.webkit.org/changeset/121603>