Bug 90318 – Allow AudioDestination to support local/live audio input

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chris Rogers]

Allow AudioDestination to support local/live audio input

[Chris Rogers]

Created attachment 150267 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Chris Rogers]

This change works with:
https://bugs.webkit.org/show_bug.cgi?id=90110

In order to help implement MediaStreamAudioSourceNode

This patch deals with the lower-level audio hardware aspects of getting local/live audio input.

[Adam Barth]

Comment on attachment 150267 [details]
Patch

API change LGTM

[Kenneth Russell]

Comment on attachment 150267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150267&action=review

Looks good overall. Couple of minor bookkeeping questions. r=me

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:326
> +    // FIXME: Add support for local/live audio input.

Is there a bug filed to track this work?

> Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp:158
> +    // FIXME: Add support for local/live audio input.

Same question.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:133
> +    // FIXME: Add support for local/live audio input.

Here too.

[Chris Rogers]

Committed r124264: <http://trac.webkit.org/changeset/124264>

[Philippe Normand]

(In reply to comment #5)
> (From update of attachment 150267 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150267&action=review
> 
> Looks good overall. Couple of minor bookkeeping questions. r=me
> 
> > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:326
> > +    // FIXME: Add support for local/live audio input.
> 
> Is there a bug filed to track this work?
> 

I'll try to take care of this one soon.