RESOLVED INVALID90317
[V8] Use WebCore::root for V8 bindings too 
https://bugs.webkit.org/show_bug.cgi?id=90317
Summary [V8] Use WebCore::root for V8 bindings too
Erik Arvidsson
Reported 2012-06-29 15:39:04 PDT
I've been working on GenerateIsReachable related stuff and it seems like we should use WebCore::root too. I think we can get rid of all non Node cases by delegating to the WebCore::root value.
Attachments
Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-06-29 18:31:56 PDT
(In reply to comment #0) > it seems like we should use WebCore::root too. I think we can get rid of all non Node cases by delegating to the WebCore::root value. I would guess root() is not a WebCore method but a method implemented in JSDOMBinding.h. We might want to move it to Node.h so that both JSC and V8 can use it. > I've been working on GenerateIsReachable related stuff Just in case, would you elaborate on the overall goal of the work?
Erik Arvidsson
Comment 2 2012-07-02 09:38:17 PDT
(In reply to comment #1) > (In reply to comment #0) > > it seems like we should use WebCore::root too. I think we can get rid of all non Node cases by delegating to the WebCore::root value. > > I would guess root() is not a WebCore method but a method implemented in JSDOMBinding.h. We might want to move it to Node.h so that both JSC and V8 can use it. Yeah, right now these are only used by the JSC bindings. I was thinking to put them in Source/WebCore/bindings/. Node.h is not the right place for these. Some of them are unrelated to Nodes (WebCore::root(StyleSheet*) for example). > Just in case, would you elaborate on the overall goal of the work? There are two goals here. 1. Correctness. Reachable wrappers should not be collected. 2. Security. If GC is observable it can be used as a covert channel.
Brian Burg
Comment 3 2014-12-16 00:48:16 PST
Closing some V8-related work items.
Note You need to log in before you can comment on or make changes to this bug.