Bug 90302 - Remove warning about protected values when the Heap is being destroyed
Summary: Remove warning about protected values when the Heap is being destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-29 13:03 PDT by Mark Hahnenberg
Modified: 2012-06-29 18:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2012-06-29 13:12 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-06-29 13:03:22 PDT
Having to do book-keeping about whether values allocated from a certain VM are or are not protected makes the JSC API much more difficult to use correctly. Clients should be able to throw an entire VM away and not have to worry about unprotecting all of the values that they protected earlier.
Comment 1 Mark Hahnenberg 2012-06-29 13:12:45 PDT
Created attachment 150241 [details]
Patch
Comment 2 Mark Hahnenberg 2012-06-29 13:15:13 PDT
<rdar://problem/11760002>
Comment 3 Geoffrey Garen 2012-06-29 13:46:45 PDT
Comment on attachment 150241 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2012-06-29 18:14:25 PDT
Comment on attachment 150241 [details]
Patch

Clearing flags on attachment: 150241

Committed r121607: <http://trac.webkit.org/changeset/121607>
Comment 5 WebKit Review Bot 2012-06-29 18:14:29 PDT
All reviewed patches have been landed.  Closing bug.