Bug 90299 - Remove type from screenColorProfile API
Summary: Remove type from screenColorProfile API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Payne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-29 11:31 PDT by Tony Payne
Modified: 2012-06-29 16:40 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.73 KB, patch)
2012-06-29 11:32 PDT, Tony Payne 		no flags Details | Formatted Diff | Diff
Patch (8.73 KB, patch)
2012-06-29 11:37 PDT, Tony Payne 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Payne 2012-06-29 11:31:06 PDT 
Remove type from screenColorProfile API
Comment 1 Tony Payne 2012-06-29 11:32:33 PDT 
Created attachment 150223 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-29 11:35:41 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-06-29 11:36:05 PDT 
Attachment 150223 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tony Payne 2012-06-29 11:37:49 PDT 
Created attachment 150227 [details]
Patch
Comment 5 Adam Barth 2012-06-29 13:56:21 PDT 
Comment on attachment 150227 [details]
Patch

Thanks.
Comment 6 WebKit Review Bot 2012-06-29 16:40:51 PDT 
Comment on attachment 150227 [details]
Patch

Clearing flags on attachment: 150227

Committed r121600: <http://trac.webkit.org/changeset/121600>
Comment 7 WebKit Review Bot 2012-06-29 16:40:56 PDT 
All reviewed patches have been landed.  Closing bug.