RESOLVED INVALID 90293
Web Inspector: TextViewer's interaction with its panels should be event based 
https://bugs.webkit.org/show_bug.cgi?id=90293
Summary Web Inspector: TextViewer's interaction with its panels should be event based
Vsevolod Vlasov
Reported 2012-06-29 10:10:37 PDT
I'd like to add some interaction between TextViewer and TextEditorMainPanel and it feels like current implementation of such interaction is not very scalable.
Attachments
Patch (24.27 KB, patch)
2012-06-29 10:14 PDT, Vsevolod Vlasov 		pfeldman: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-06-29 10:14:32 PDT
Created attachment 150210 [details] Patch
Andrey Adaikin
Comment 2 2012-06-29 10:27:31 PDT
Comment on attachment 150210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150210&action=review > Source/WebCore/inspector/front-end/TextViewer.js:240 > + _exitedInternalTextChangeMode: function(event) update javadoc.
Pavel Feldman
Comment 3 2012-07-02 02:26:49 PDT
Comment on attachment 150210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150210&action=review > Source/WebCore/inspector/front-end/TextViewer.js:975 > + this._gutterPanel.dispatchEventToListeners(WebInspector.TextEditorChunkedPanel.Events.DecorationsForLineSyncNeeded, this.startLine); I would instead pass the delegate into the main panel.
Brian Burg
Comment 4 2014-12-12 14:37:32 PST
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.
Note You need to log in before you can comment on or make changes to this bug.