Bug 90293 - Web Inspector: TextViewer's interaction with its panels should be event based
Summary: Web Inspector: TextViewer's interaction with its panels should be event based
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks: 90294
  Show dependency tree / graph
 
Reported: 2012-06-29 10:10 PDT by Vsevolod Vlasov
Modified: 2014-12-12 14:37 PST (History)
10 users (show)

See Also:

Attachments
Patch (24.27 KB, patch)
2012-06-29 10:14 PDT, Vsevolod Vlasov 		pfeldman: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-06-29 10:10:37 PDT 
I'd like to add some interaction between TextViewer and TextEditorMainPanel and it feels like current implementation of such interaction is not very scalable.
Comment 1 Vsevolod Vlasov 2012-06-29 10:14:32 PDT 
Created attachment 150210 [details]
Patch
Comment 2 Andrey Adaikin 2012-06-29 10:27:31 PDT 
Comment on attachment 150210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150210&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:240
> +    _exitedInternalTextChangeMode: function(event)

update javadoc.
Comment 3 Pavel Feldman 2012-07-02 02:26:49 PDT 
Comment on attachment 150210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150210&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:975
> +            this._gutterPanel.dispatchEventToListeners(WebInspector.TextEditorChunkedPanel.Events.DecorationsForLineSyncNeeded, this.startLine);

I would instead pass the delegate into the main panel.
Comment 4 Brian Burg 2014-12-12 14:37:32 PST 
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.