The backing store doesn't know when the API client swaps the buffers, so it doesn't know when to signal the blit generation condvar. Instead, use EGL fence sync when available, so we don't have to know. This is PR152132
Created attachment 155476 [details] Patch
Comment on attachment 155476 [details] Patch LGTM.
Comment on attachment 155476 [details] Patch Rejecting attachment 155476 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ingStore_p.h Hunk #1 succeeded at 369 (offset 1 line). patching file Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.cpp patching file Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.h patching file Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp patching file Source/WebKit/blackberry/WebKitSupport/SurfacePool.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13404035
Created attachment 155524 [details] Patch
Comment on attachment 155524 [details] Patch New patch without merge conflicts this time...
Comment on attachment 155524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155524&action=review > Source/WebKit/blackberry/Api/BackingStore.cpp:1133 > + // TODO: This code is only needed for EGLImage code path, but preferrably BackingStore WebKit generally uses FIXME > Source/WebKit/blackberry/Api/BackingStore.cpp:1538 > + // TODO: This code is only needed for EGLImage code path, but preferrably BackingStore ditto
Comment on attachment 155524 [details] Patch LGTM.
Comment on attachment 155524 [details] Patch Clearing flags on attachment: 155524 Committed r124199: <http://trac.webkit.org/changeset/124199>
All reviewed patches have been landed. Closing bug.
I forgot to say in the changelog, this is PR 152132