Bug 90287 - [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
Summary: [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
Status: RESOLVED DUPLICATE of bug 90286
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-29 08:43 PDT by Sudarsana Nagineni (babu)
Modified: 2012-07-05 00:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2012-06-29 08:57 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Patch (4.18 KB, patch)
2012-07-01 06:09 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-06-29 08:43:09 PDT 
fast/viewport/viewport-91.html is failing after r121555 and should be skipped until bug 90286 is fixed.
Comment 1 Sudarsana Nagineni (babu) 2012-06-29 08:57:18 PDT 
Created attachment 150192 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-29 11:52:38 PDT 
Comment on attachment 150192 [details]
Patch

Clearing flags on attachment: 150192

Committed r121579: <http://trac.webkit.org/changeset/121579>
Comment 3 WebKit Review Bot 2012-06-29 11:52:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Balazs Kelemen 2012-07-01 03:46:50 PDT 
Doesn't it mean that the patch is bad? If so, why don't we revert instead? Or maybe we just need to change some call sites in wk2 platform code?
Comment 5 Balazs Kelemen 2012-07-01 05:43:18 PDT 
Here is the diff on Qt:

-viewport size 320x356 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000
+viewport size 480x534 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000

Relevant parts of the test:
<meta name="viewport" content="width=device-width">
layoutTestController.dumpConfigurationForViewport(240, 480, 564, 480, 534);

So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites.
Comment 6 Balazs Kelemen 2012-07-01 06:09:41 PDT 
Reopening to attach new patch.
Comment 7 Balazs Kelemen 2012-07-01 06:09:50 PDT 
Created attachment 150329 [details]
Patch
Comment 8 Balazs Kelemen 2012-07-01 06:11:38 PDT 
> So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites.

... but it turned it to an int division :)
Comment 9 Konrad Piascik 2012-07-01 06:23:28 PDT 
I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286  But commit queue was being a little stupid so I'd need to re-submit.  I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine.
Comment 10 Build Bot 2012-07-01 06:34:50 PDT 
Comment on attachment 150329 [details]
Patch

Attachment 150329 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13113854
Comment 11 Balazs Kelemen 2012-07-02 00:38:44 PDT 
(In reply to comment #9)
> I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286  But commit queue was being a little stupid so I'd need to re-submit.  I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine.

Well, my patch did not build on Windows, so instead I lent your patch - http://trac.webkit.org/changeset/121661.

*** This bug has been marked as a duplicate of bug 90286 ***