Bug 90271 – [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT

• Status: CLOSED
• Resolution: FIXED
• Component: Tools / Tests

[Xiaobo Wang]

Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not defined by default.
We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't need to rebuild webkit before running DRT.

[Xiaobo Wang]

RIM PR #154707

[Xiaobo Wang]

Created attachment 150149 [details]
Git patch

[Rob Buis]

Comment on attachment 150149 [details]
Git patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150149&action=review

Looks good.

> Source/WebKit/PlatformBlackBerry.cmake:27
> +IF ( NOT PUBLIC_BUILD)

Space character not needed.

[Xiaobo Wang]

Created attachment 150153 [details]
Git patch

Removed a unneeded space.

[Rob Buis]

Comment on attachment 150153 [details]
Git patch

Looks good.

[WebKit Review Bot]

Comment on attachment 150153 [details]
Git patch

Rejecting attachment 150153 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 144734 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 144734.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13120287

[Rob Buis]

(In reply to comment #6)
> (From update of attachment 150153 [details])
> Rejecting attachment 150153 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
> 
> Last 500 characters of output:
> webkit-commit-queue/Source/WebKit/chromium/webkit --revision 144734 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 48>At revision 144734.
> 
> ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 
> ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> Updating webkit projects from gyp files...
> 
> Full output: http://queues.webkit.org/results/13120287

Oops, needs removal of OOPS.

[Rob Buis]

(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 150153 [details] [details])
> > Rejecting attachment 150153 [details] [details] from commit-queue.
> > 
> > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
> > 
> > Last 500 characters of output:
> > webkit-commit-queue/Source/WebKit/chromium/webkit --revision 144734 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > 48>At revision 144734.
> > 
> > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > 
> > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > Updating webkit projects from gyp files...
> > 
> > Full output: http://queues.webkit.org/results/13120287
> 
> Oops, needs removal of OOPS.

More specifically, in Tools/ChangeLog the Reviewed by line is duplicated.

[Xiaobo Wang]

Created attachment 150355 [details]
Git patch

Removed redundant "Reviewed by NOBODY (OOPS!)." in Tools/ChangeLog.

[WebKit Review Bot]

Comment on attachment 150355 [details]
Git patch

Clearing flags on attachment: 150355

Committed r121725: <http://trac.webkit.org/changeset/121725>

[Eric Seidel (no email)]

Comment on attachment 150149 [details]
Git patch

Cleared Rob Buis's review+ from obsolete attachment 150149 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Xiaobo Wang]

The patch has landed, resolve as fixed.

[Xiaobo Wang]

close it