Efl needs a test case for navigator.language. This test case is modified for all ports. And I would like to move to fast/js. I checked this on the qt, gtk, mac and efl.
Fast/js is where JavaScript-only tests live, i.e. ones that don't depend on browser DOM. So, both current and suggested places are wrong.
(In reply to comment #1) > Fast/js is where JavaScript-only tests live, i.e. ones that don't depend on browser DOM. So, both current and suggested places are wrong. Originally this test case is in the fast/js before it was moved to platform/qt/fast/js. (bug 83710) It was my reason for moving to fast/js. Could you tell me where is proper position for this?
Created attachment 150154 [details] Patch
Anders, could you check this patch please? Because I rolled back your change.(bug 83710)
Comment on attachment 150154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150154&action=review > LayoutTests/fast/js/navigator-language.html:10 > + <head> > + <script src="../../fast/js/resources/js-test-pre.js"></script> > + </head> > + <body> > + <script> > + description( > + "<pre>Check return value of navigator.language." > + ); Why are you indenting elements and scripts like this? We don't normally do this. Also, please use svn mv. > LayoutTests/fast/js/navigator-language.html:18 > + shouldBe("language", "'en'"); We use 4-space indentation, not tabs.
Created attachment 150288 [details] Patch
(In reply to comment #5) > (From update of attachment 150154 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150154&action=review > > > LayoutTests/fast/js/navigator-language.html:10 > > + <head> > > + <script src="../../fast/js/resources/js-test-pre.js"></script> > > + </head> > > + <body> > > + <script> > > + description( > > + "<pre>Check return value of navigator.language." > > + ); > > Why are you indenting elements and scripts like this? We don't normally do this. > Also, please use svn mv. > > > LayoutTests/fast/js/navigator-language.html:18 > > + shouldBe("language", "'en'"); > > We use 4-space indentation, not tabs. It was my mistake. They were fixed.
Comment on attachment 150288 [details] Patch Again, you didn't use svn mv.
(In reply to comment #8) > (From update of attachment 150288 [details]) > Again, you didn't use svn mv. But, I need to change test case and expected result. After I change the file, git makes them to new file. Do you have a way for keeping it 'renamed'?
(In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 150288 [details] [details]) > > Again, you didn't use svn mv. > > But, I need to change test case and expected result. > After I change the file, git makes them to new file. > Do you have a way for keeping it 'renamed'? Don't use git for this. Use a svn checkout for patches like this.
Created attachment 150354 [details] patch
Comment on attachment 150354 [details] patch Clearing flags on attachment: 150354 Committed r121656: <http://trac.webkit.org/changeset/121656>
All reviewed patches have been landed. Closing bug.