RESOLVED FIXED 90261
Move platform/qt/fast/js/navigator-language.html to fast/js. 
https://bugs.webkit.org/show_bug.cgi?id=90261
Summary Move platform/qt/fast/js/navigator-language.html to fast/js.
Kihong Kwon
Reported 2012-06-29 02:16:38 PDT
Efl needs a test case for navigator.language. This test case is modified for all ports. And I would like to move to fast/js. I checked this on the qt, gtk, mac and efl.
Attachments
Patch (4.36 KB, patch)
2012-06-29 05:31 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (4.21 KB, patch)
2012-06-29 18:44 PDT, Kihong Kwon 		rniwa: review-
rniwa: commit-queue-
DetailsFormatted DiffDiff
patch (6.96 KB, patch)
2012-07-01 19:33 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-06-29 04:57:42 PDT
Fast/js is where JavaScript-only tests live, i.e. ones that don't depend on browser DOM. So, both current and suggested places are wrong.
Kihong Kwon
Comment 2 2012-06-29 05:24:10 PDT
(In reply to comment #1) > Fast/js is where JavaScript-only tests live, i.e. ones that don't depend on browser DOM. So, both current and suggested places are wrong. Originally this test case is in the fast/js before it was moved to platform/qt/fast/js. (bug 83710) It was my reason for moving to fast/js. Could you tell me where is proper position for this?
Kihong Kwon
Comment 3 2012-06-29 05:31:51 PDT
Created attachment 150154 [details] Patch
Kihong Kwon
Comment 4 2012-06-29 05:36:17 PDT
Anders, could you check this patch please? Because I rolled back your change.(bug 83710)
Ryosuke Niwa
Comment 5 2012-06-29 12:28:58 PDT
Comment on attachment 150154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150154&action=review > LayoutTests/fast/js/navigator-language.html:10 > + <head> > + <script src="../../fast/js/resources/js-test-pre.js"></script> > + </head> > + <body> > + <script> > + description( > + "<pre>Check return value of navigator.language." > + ); Why are you indenting elements and scripts like this? We don't normally do this. Also, please use svn mv. > LayoutTests/fast/js/navigator-language.html:18 > + shouldBe("language", "'en'"); We use 4-space indentation, not tabs.
Kihong Kwon
Comment 6 2012-06-29 18:44:27 PDT
Created attachment 150288 [details] Patch
Kihong Kwon
Comment 7 2012-06-29 18:45:24 PDT
(In reply to comment #5) > (From update of attachment 150154 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150154&action=review > > > LayoutTests/fast/js/navigator-language.html:10 > > + <head> > > + <script src="../../fast/js/resources/js-test-pre.js"></script> > > + </head> > > + <body> > > + <script> > > + description( > > + "<pre>Check return value of navigator.language." > > + ); > > Why are you indenting elements and scripts like this? We don't normally do this. > Also, please use svn mv. > > > LayoutTests/fast/js/navigator-language.html:18 > > + shouldBe("language", "'en'"); > > We use 4-space indentation, not tabs. It was my mistake. They were fixed.
Ryosuke Niwa
Comment 8 2012-06-29 18:56:10 PDT
Comment on attachment 150288 [details] Patch Again, you didn't use svn mv.
Kihong Kwon
Comment 9 2012-06-29 19:57:25 PDT
(In reply to comment #8) > (From update of attachment 150288 [details]) > Again, you didn't use svn mv. But, I need to change test case and expected result. After I change the file, git makes them to new file. Do you have a way for keeping it 'renamed'?
Ryosuke Niwa
Comment 10 2012-06-29 20:06:45 PDT
(In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 150288 [details] [details]) > > Again, you didn't use svn mv. > > But, I need to change test case and expected result. > After I change the file, git makes them to new file. > Do you have a way for keeping it 'renamed'? Don't use git for this. Use a svn checkout for patches like this.
Kihong Kwon
Comment 11 2012-07-01 19:33:27 PDT
Created attachment 150354 [details] patch
WebKit Review Bot
Comment 12 2012-07-01 22:22:13 PDT
Comment on attachment 150354 [details] patch Clearing flags on attachment: 150354 Committed r121656: <http://trac.webkit.org/changeset/121656>
WebKit Review Bot
Comment 13 2012-07-01 22:22:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.