Bug 90245 - updateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING)
Summary: updateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 21:20 PDT by Simon Fraser (smfr)
Modified: 2012-06-29 20:42 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2012-06-29 20:28 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-06-28 21:20:25 PDT
RenderLayer::styleChanged() has:

#if USE(ACCELERATED_COMPOSITING)
    updateDescendantDependentFlags();
    updateTransform();

Seems like both should be outside the #ifdef
Comment 1 Simon Fraser (smfr) 2012-06-29 20:28:02 PDT
Created attachment 150298 [details]
Patch
Comment 2 mitz 2012-06-29 20:31:18 PDT
Comment on attachment 150298 [details]
Patch

Do you have a test to prove this?
Comment 3 Simon Fraser (smfr) 2012-06-29 20:32:14 PDT
I do not; i just noticed this when looking at the code. I'm not sure any of the top tier platforms build with accelerated compositing off any more.
Comment 4 Simon Fraser (smfr) 2012-06-29 20:42:28 PDT
http://trac.webkit.org/changeset/121616