Bug 90235 – [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kenichi Ishibashi]

As of r120234, Chromium mac port should pass LayoutTests/css3/font-feature-settings-rendering.html, but it's failing on bots (the current expectation is MISSING, though).
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=font-feature-settings-rendering

When I tested the patch, I used 10.6 sdk. However, it seems that bots and Chrome official build use 10.5 sdk and CTFontCopyTable of 10.5 sdk doesn't work as expected. We need to use CGFontCopyTableForTag instead.

[Kenichi Ishibashi]

Created attachment 150057 [details]
Patch

[Kenichi Ishibashi]

Kent-san, could you rubber-stamp? I checked the patch works with 10.5 sdk.

[Kent Tamura]

Comment on attachment 150057 [details]
Patch

rubber-stamped

[Kenichi Ishibashi]

Comment on attachment 150057 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 150057 [details]
Patch

Clearing flags on attachment: 150057

Committed r121510: <http://trac.webkit.org/changeset/121510>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

BTW, We won't support OS X 10.5 since M22.

[Kenichi Ishibashi]

(In reply to comment #7)
> BTW, We won't support OS X 10.5 since M22.

Thanks you for the heads-up. CGFontCopyTableForTag isn't deprecated so it should work. In any case, I'm happy to rewrite the code to use CoreText APIs after bots and official build start using 10.6 sdk (or later).