Bug 90235 - [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
Summary: [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 18:15 PDT by Kenichi Ishibashi
Modified: 2012-06-29 00:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2012-06-28 18:20 PDT, Kenichi Ishibashi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-06-28 18:15:20 PDT 
As of r120234, Chromium mac port should pass LayoutTests/css3/font-feature-settings-rendering.html, but it's failing on bots (the current expectation is MISSING, though).
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=font-feature-settings-rendering

When I tested the patch, I used 10.6 sdk. However, it seems that bots and Chrome official build use 10.5 sdk and CTFontCopyTable of 10.5 sdk doesn't work as expected. We need to use CGFontCopyTableForTag instead.
Comment 1 Kenichi Ishibashi 2012-06-28 18:20:48 PDT 
Created attachment 150057 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-06-28 18:22:54 PDT 
Kent-san, could you rubber-stamp? I checked the patch works with 10.5 sdk.
Comment 3 Kent Tamura 2012-06-28 18:25:36 PDT 
Comment on attachment 150057 [details]
Patch

rubber-stamped
Comment 4 Kenichi Ishibashi 2012-06-28 18:31:04 PDT 
Comment on attachment 150057 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-06-28 19:38:05 PDT 
Comment on attachment 150057 [details]
Patch

Clearing flags on attachment: 150057

Committed r121510: <http://trac.webkit.org/changeset/121510>
Comment 6 WebKit Review Bot 2012-06-28 19:38:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Kent Tamura 2012-06-29 00:29:39 PDT 
BTW, We won't support OS X 10.5 since M22.
Comment 8 Kenichi Ishibashi 2012-06-29 00:40:51 PDT 
(In reply to comment #7)
> BTW, We won't support OS X 10.5 since M22.

Thanks you for the heads-up. CGFontCopyTableForTag isn't deprecated so it should work. In any case, I'm happy to rewrite the code to use CoreText APIs after bots and official build start using 10.6 sdk (or later).