Bug 90232 – add a pylint wrapper for linting python code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

add a pylint wrapper for linting python code

[Dirk Pranke]

Created attachment 150053 [details]
Patch

[Dirk Pranke]

the pylintrc file is cloned from the one chromium uses in depot_tools, tweaked to follow webkit's coding standards roughly. I will probably want to tweak it some more once I've run it over more of the codebase.

[Adam Barth]

Comment on attachment 150053 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150053&action=review

We'll want to integrate this into check-webkit-style at some point so that it gets run automagically.

> Tools/Scripts/webkitpy/pylintrc:43
> +ignore=CVS

Do we need to say something about SVN here?

> Tools/Scripts/webkitpy/pylintrc:130
> +init-import=no

We'd like to do this at some point.  Importing into __init__ turns out to be sketchier than we realized.

[Dirk Pranke]

(In reply to comment #3)
> (From update of attachment 150053 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150053&action=review
> 
> We'll want to integrate this into check-webkit-style at some point so that it gets run automagically.
> 
> > Tools/Scripts/webkitpy/pylintrc:43
> > +ignore=CVS
> 
> Do we need to say something about SVN here?
> 

Possibly; I haven't tried this under svn yet.

> > Tools/Scripts/webkitpy/pylintrc:130
> > +init-import=no
> 
> We'd like to do this at some point.  Importing into __init__ turns out to be sketchier than we realized.

Yeah, there's probably a few things we should turn on.

Also, I need to fix the license text in lint-webkitpy. Somehow the version I added the text to didn't get included in the patch.

[Dirk Pranke]

Committed r121502: <http://trac.webkit.org/changeset/121502>