RESOLVED FIXED 90232
add a pylint wrapper for linting python code
https://bugs.webkit.org/show_bug.cgi?id=90232
Summary add a pylint wrapper for linting python code
Dirk Pranke
Reported 2012-06-28 18:00:15 PDT
add a pylint wrapper for linting python code
Attachments
Patch (13.79 KB, patch)
2012-06-28 18:05 PDT, Dirk Pranke
abarth: review+
Dirk Pranke
Comment 1 2012-06-28 18:05:06 PDT
Dirk Pranke
Comment 2 2012-06-28 18:06:19 PDT
the pylintrc file is cloned from the one chromium uses in depot_tools, tweaked to follow webkit's coding standards roughly. I will probably want to tweak it some more once I've run it over more of the codebase.
Adam Barth
Comment 3 2012-06-28 18:10:50 PDT
Comment on attachment 150053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150053&action=review We'll want to integrate this into check-webkit-style at some point so that it gets run automagically. > Tools/Scripts/webkitpy/pylintrc:43 > +ignore=CVS Do we need to say something about SVN here? > Tools/Scripts/webkitpy/pylintrc:130 > +init-import=no We'd like to do this at some point. Importing into __init__ turns out to be sketchier than we realized.
Dirk Pranke
Comment 4 2012-06-28 18:13:09 PDT
(In reply to comment #3) > (From update of attachment 150053 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150053&action=review > > We'll want to integrate this into check-webkit-style at some point so that it gets run automagically. > > > Tools/Scripts/webkitpy/pylintrc:43 > > +ignore=CVS > > Do we need to say something about SVN here? > Possibly; I haven't tried this under svn yet. > > Tools/Scripts/webkitpy/pylintrc:130 > > +init-import=no > > We'd like to do this at some point. Importing into __init__ turns out to be sketchier than we realized. Yeah, there's probably a few things we should turn on. Also, I need to fix the license text in lint-webkitpy. Somehow the version I added the text to didn't get included in the patch.
Dirk Pranke
Comment 5 2012-06-28 18:46:19 PDT
Note You need to log in before you can comment on or make changes to this bug.