We are building WebKit using gcc 4.7. And we need option "-Wno-c++0x-compat" for a successful build. The gcc_version condition to control this in "WebCore.gyp" and other gyp files is "... gcc_version==46", should be replaced with "... gcc_version>=46". To reproduce, compile WebKit using gcc 4.7, you'll get something like this - Source/WTF/wtf/NullPtr.h:52:1: error: identifier ‘nullptr’ is a keyword in C++11 [-Werror=c++0x-compat] cc1plus: all warnings being treated as errors
Ping?
Created attachment 153119 [details] proposed patch
Created attachment 153334 [details] Updated patchset - 2.
Please update the patch for ToT.
Created attachment 153373 [details] Updated for ToT
(In reply to comment #4) > Please update the patch for ToT. Done thanks!
Oops, sorry, I meant to cc tony, not andersca. Please update the bug title in the change log (prefix with [Chromium]).
(In reply to comment #7) > Oops, sorry, I meant to cc tony, not andersca. > > Please update the bug title in the change log (prefix with [Chromium]). Yeah, the title is already prefixed with [Chromium], though I think someone else changed it. Thanks!
(In reply to comment #8) > (In reply to comment #7) > > Oops, sorry, I meant to cc tony, not andersca. > > > > Please update the bug title in the change log (prefix with [Chromium]). > > Yeah, the title is already prefixed with [Chromium], though I think someone else changed it. Thanks! I changed it.
Comment on attachment 153373 [details] Updated for ToT This patch is missing a ChangeLog. I'll fix it and upload a new copy.
(In reply to comment #10) > (From update of attachment 153373 [details]) > This patch is missing a ChangeLog. I'll fix it and upload a new copy. Oh, Tony, thanks a lot! -Han
Created attachment 153545 [details] Patch for landing
Comment on attachment 153545 [details] Patch for landing Rejecting attachment 153545 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13317236
Comment on attachment 153545 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=153545&action=review > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). You need to remove this.
Created attachment 153559 [details] Patch for landing
Comment on attachment 153559 [details] Patch for landing Clearing flags on attachment: 153559 Committed r123253: <http://trac.webkit.org/changeset/123253>
All reviewed patches have been landed. Closing bug.