Bug 90223 - Update FIXME comment in XMLDocumentParser::wellFormed
Summary: Update FIXME comment in XMLDocumentParser::wellFormed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 16:22 PDT by Kwang Yul Seo
Modified: 2012-06-29 08:28 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2012-06-28 16:24 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-06-28 16:22:20 PDT 
XMLDocumentParser::wellFormed is still used by the XMLHttpRequest to check if the responseXML was well formed. So it can't be removed.
Comment 1 Kwang Yul Seo 2012-06-28 16:24:54 PDT 
Created attachment 150041 [details]
Patch
Comment 2 Kwang Yul Seo 2012-06-28 23:33:44 PDT 
BTW, it is weird to have wellFormed method in DecodedDataDocumentParser class because it is used only by the XMLDocumentParser.
Comment 3 Adam Barth 2012-06-29 07:42:39 PDT 
Comment on attachment 150041 [details]
Patch

Thanks.  Yeah, it's a bit odd to have in decoded document parser, but probably not problematic.
Comment 4 WebKit Review Bot 2012-06-29 08:27:59 PDT 
Comment on attachment 150041 [details]
Patch

Clearing flags on attachment: 150041

Committed r121564: <http://trac.webkit.org/changeset/121564>
Comment 5 WebKit Review Bot 2012-06-29 08:28:09 PDT 
All reviewed patches have been landed.  Closing bug.