Bug 90216 - Undo handling in WebKit2 is not robust against some page-closing code paths
Summary: Undo handling in WebKit2 is not robust against some page-closing code paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Major
Assignee: John Sullivan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-06-28 15:55 PDT by John Sullivan
Modified: 2013-03-16 22:38 PDT (History)
0 users

See Also:

Attachments
Patch that clears Undo actions when the WKView moves to another window (including the nil window) (2.73 KB, patch)
2012-06-28 16:03 PDT, John Sullivan 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2012-06-28 15:55:40 PDT 
This is in radar as <rdar://problem/11766518>

PageClientImpl registers entries on the undo stack, but does not guarantee that all such entries will be removed from the undo stack before the PageClientImpl is dealloc'ed. This leads to some code paths in which a bad undo target can be left on the undo stack, leading to a crash when Undo is then performed.
Comment 1 John Sullivan 2012-06-28 16:03:15 PDT 
Created attachment 150034 [details]
Patch that clears Undo actions when the WKView moves to another window (including the nil window)
Comment 2 Enrica Casucci 2012-06-28 16:12:05 PDT 
Comment on attachment 150034 [details]
Patch that clears Undo actions when the WKView moves to another window (including the nil window)

Looks good to me
Comment 3 Alexey Proskuryakov 2013-03-16 22:38:02 PDT 
This was committed in <http://trac.webkit.org/changeset/121482>.