RESOLVED FIXED90215
[GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree 
https://bugs.webkit.org/show_bug.cgi?id=90215
Summary [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
Tony Chang
Reported 2012-06-28 15:33:26 PDT
[GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
Attachments
Patch (3.20 KB, patch)
2012-06-28 15:34 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (4.81 KB, patch)
2012-06-28 16:05 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-06-28 15:34:20 PDT
Created attachment 150026 [details] Patch
Tony Chang
Comment 2 2012-06-28 15:36:46 PDT
I ran: WEBKITOUTPUTDIR=/src/WebKit/gtkbuild build-webkit --gtk which properly built everything into /src/WebKit/gtkbuild. When I tried to run WEBKITOUTPUTDIR=/src/WebKit/gtkbuild new-run-webkit-tests --gtk I get a crash because it's unable to find the test fonts.
Martin Robinson
Comment 3 2012-06-28 15:41:56 PDT
Comment on attachment 150026 [details] Patch Great! Though this should probably also happen for WebKitTestRunner as well in Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp.
Tony Chang
Comment 4 2012-06-28 15:54:06 PDT
Comment on attachment 150026 [details] Patch Oops, will fix WTR too.
Tony Chang
Comment 5 2012-06-28 16:05:45 PDT
Created attachment 150037 [details] Patch
Martin Robinson
Comment 6 2012-06-28 16:14:08 PDT
Comment on attachment 150037 [details] Patch Thank you very much for fixing this. You are both an engineer and a gentleman.
WebKit Review Bot
Comment 7 2012-06-28 18:18:54 PDT
Comment on attachment 150037 [details] Patch Clearing flags on attachment: 150037 Committed r121499: <http://trac.webkit.org/changeset/121499>
WebKit Review Bot
Comment 8 2012-06-28 18:18:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.