Bug 90215 - [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
Summary: [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 15:33 PDT by Tony Chang
Modified: 2012-06-28 18:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.20 KB, patch)
2012-06-28 15:34 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (4.81 KB, patch)
2012-06-28 16:05 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-06-28 15:33:26 PDT 
[GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
Comment 1 Tony Chang 2012-06-28 15:34:20 PDT 
Created attachment 150026 [details]
Patch
Comment 2 Tony Chang 2012-06-28 15:36:46 PDT 
I ran:
  WEBKITOUTPUTDIR=/src/WebKit/gtkbuild build-webkit --gtk
which properly built everything into /src/WebKit/gtkbuild.  When I tried to run
  WEBKITOUTPUTDIR=/src/WebKit/gtkbuild new-run-webkit-tests --gtk
I get a crash because it's unable to find the test fonts.
Comment 3 Martin Robinson 2012-06-28 15:41:56 PDT 
Comment on attachment 150026 [details]
Patch

Great! Though this should probably also happen for WebKitTestRunner as well in Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp.
Comment 4 Tony Chang 2012-06-28 15:54:06 PDT 
Comment on attachment 150026 [details]
Patch

Oops, will fix WTR too.
Comment 5 Tony Chang 2012-06-28 16:05:45 PDT 
Created attachment 150037 [details]
Patch
Comment 6 Martin Robinson 2012-06-28 16:14:08 PDT 
Comment on attachment 150037 [details]
Patch

Thank you very much for fixing this. You are both an engineer and a gentleman.
Comment 7 WebKit Review Bot 2012-06-28 18:18:54 PDT 
Comment on attachment 150037 [details]
Patch

Clearing flags on attachment: 150037

Committed r121499: <http://trac.webkit.org/changeset/121499>
Comment 8 WebKit Review Bot 2012-06-28 18:18:59 PDT 
All reviewed patches have been landed.  Closing bug.