RESOLVED FIXED 90213
Clean up m_data in ReferenceFilterOperation 
https://bugs.webkit.org/show_bug.cgi?id=90213
Summary Clean up m_data in ReferenceFilterOperation
Stephen White
Reported 2012-06-28 14:57:02 PDT
We currently use a void* m_data to track the cached SVG document (if any) corresponding to a ReferenceFilterOperation. It isn't used down at the platform/graphics/filter level (and would be a layer violation if it was). We should probably find a better way to do this. Here was my comment on the original bug: "I really would rather have this data stored in a hash table at a higher level, but I seem to be hamstrung by data hiding. StyleResolver knows about the WebKitCSSSVGDocumentValue (where the CachedSVGDocument lives), and uses it to load the SVG document, but RenderLayerFilterInfo and FilterEffectRenderer only get the FilterOperations, not the WebKitCSSSVGDocumentValue. This void* is only to get the pointer from one place to the other two, so there's no real interface to be defined down at the FilterOperation level, since it doesn't do anything with it. If there's a better way to do that, I'm definitely interested."
Attachments
Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2012-10-29 19:44:43 PDT
This was fixed by http://trac.webkit.org/changeset/132528.
Note You need to log in before you can comment on or make changes to this bug.