Bug 90210 – [Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page

[Adam Barth]

Created attachment 150016 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Leandro Graciá Gil]

lgtm.

[Dimitri Glazkov (Google)]

Comment on attachment 150016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150016&action=review

> Source/WebKit/chromium/public/WebViewClient.h:375
> +    virtual WebContentDetectionResult detechContentAround(const WebHitTestResult&) { return WebContentDetectionResult(); }

detech -> detect?

[Adam Barth]

(In reply to comment #4)
> (From update of attachment 150016 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150016&action=review
> 
> > Source/WebKit/chromium/public/WebViewClient.h:375
> > +    virtual WebContentDetectionResult detechContentAround(const WebHitTestResult&) { return WebContentDetectionResult(); }
> 
> detech -> detect?

Yep.  Thanks!

[Adam Barth]

Created attachment 150028 [details]
Patch for landing

[Adam Barth]

Comment on attachment 150028 [details]
Patch for landing

Clearing flags on attachment: 150028

Committed r121483: <http://trac.webkit.org/changeset/121483>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.