WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
90204
Fix rebaselining for Qt and Apple ports
https://bugs.webkit.org/show_bug.cgi?id=90204
Summary
Fix rebaselining for Qt and Apple ports
Ojan Vafai
Reported
2012-06-28 14:09:33 PDT
Fix rebaselining for Qt and Apple ports
Attachments
Patch
(11.34 KB, patch)
2012-06-28 14:11 PDT
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
Patch
(7.36 KB, patch)
2012-06-28 15:58 PDT
,
Ojan Vafai
dpranke
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2012-06-28 14:11:07 PDT
Created
attachment 150011
[details]
Patch
Ojan Vafai
Comment 2
2012-06-28 14:12:11 PDT
With this patch, I think the rebaseline tool will work for all ports. We'll need some real-world experience to flush out edge cases I didn't think of.
Adam Barth
Comment 3
2012-06-28 14:16:05 PDT
Comment on
attachment 150011
[details]
Patch baseline_path_for_rebaseline makes sense as a concept. I'm not 100% sure about the details for each port.
Ojan Vafai
Comment 4
2012-06-28 14:18:15 PDT
(In reply to
comment #3
)
> (From update of
attachment 150011
[details]
) > baseline_path_for_rebaseline makes sense as a concept. I'm not 100% sure about the details for each port.
Yeah, I tried to do a best guess based off what I see with the existing bots and platform directories.
Ojan Vafai
Comment 5
2012-06-28 15:58:04 PDT
Created
attachment 150033
[details]
Patch
Dirk Pranke
Comment 6
2012-06-28 16:57:02 PDT
Comment on
attachment 150033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=150033&action=review
r+ w/ nits/questions.
> Tools/Scripts/webkitpy/layout_tests/port/builders.py:61 > + "Apple Win XP Debug (Tests)": {"port_name": "win-xp", "specifiers": set(["win", "debug"]), "rebaseline_override_dir": "win"},
shouldn't this be win-xp?
> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:94 > return port.baseline_path()
nit: can you change port.baseline_path() to port.baseline_version_dir() while you're at it?
> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:49 > + self.assertEqual(command._baseline_directory("Apple Win XP Debug (Tests)"), "/mock-checkout/LayoutTests/platform/win")
same comment re: -xp.
Ojan Vafai
Comment 7
2012-06-28 17:53:02 PDT
Comment on
attachment 150033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=150033&action=review
>> Tools/Scripts/webkitpy/layout_tests/port/builders.py:61 >> + "Apple Win XP Debug (Tests)": {"port_name": "win-xp", "specifiers": set(["win", "debug"]), "rebaseline_override_dir": "win"}, > > shouldn't this be win-xp?
lol-whoops. yes.
Ojan Vafai
Comment 8
2012-06-29 11:28:43 PDT
Committed
r121577
: <
http://trac.webkit.org/changeset/121577
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug