Bug 90204 – Fix rebaselining for Qt and Apple ports

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

Fix rebaselining for Qt and Apple ports

[Ojan Vafai]

Created attachment 150011 [details]
Patch

[Ojan Vafai]

With this patch, I think the rebaseline tool will work for all ports. We'll need some real-world experience to flush out edge cases I didn't think of.

[Adam Barth]

Comment on attachment 150011 [details]
Patch

baseline_path_for_rebaseline makes sense as a concept.  I'm not 100% sure about the details for each port.

[Ojan Vafai]

(In reply to comment #3)
> (From update of attachment 150011 [details])
> baseline_path_for_rebaseline makes sense as a concept.  I'm not 100% sure about the details for each port.

Yeah, I tried to do a best guess based off what I see with the existing bots and platform directories.

[Ojan Vafai]

Created attachment 150033 [details]
Patch

[Dirk Pranke]

Comment on attachment 150033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150033&action=review

r+ w/ nits/questions.

> Tools/Scripts/webkitpy/layout_tests/port/builders.py:61
> +    "Apple Win XP Debug (Tests)": {"port_name": "win-xp", "specifiers": set(["win", "debug"]), "rebaseline_override_dir": "win"},

shouldn't this be win-xp?

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:94
>          return port.baseline_path()

nit: can you change port.baseline_path() to port.baseline_version_dir() while you're at it?

> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:49
> +        self.assertEqual(command._baseline_directory("Apple Win XP Debug (Tests)"), "/mock-checkout/LayoutTests/platform/win")

same comment re: -xp.

[Ojan Vafai]

Comment on attachment 150033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150033&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/builders.py:61
>> +    "Apple Win XP Debug (Tests)": {"port_name": "win-xp", "specifiers": set(["win", "debug"]), "rebaseline_override_dir": "win"},
> 
> shouldn't this be win-xp?

lol-whoops. yes.

[Ojan Vafai]

Committed r121577: <http://trac.webkit.org/changeset/121577>