Bug 90186 - Make rebaseline-test and rebseline-expectations work for non-Chromium ports
Summary: Make rebaseline-test and rebseline-expectations work for non-Chromium ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 10:16 PDT by Ojan Vafai
Modified: 2012-06-28 12:03 PDT (History)
3 users (show)

See Also:


Attachments
Patch (13.11 KB, patch)
2012-06-28 10:23 PDT, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-06-28 10:16:16 PDT
Make rebaseline-test and rebseline-expectations work for non-Chromium ports
Comment 1 Ojan Vafai 2012-06-28 10:23:18 PDT
Created attachment 149968 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-06-28 10:24:39 PDT
\o/
Comment 3 Adam Barth 2012-06-28 11:35:16 PDT
Comment on attachment 149968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149968&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:84
> +        if port.name().startswith('chromium-'):

Should we have a way to ask the port whether it's a Chromium port rather than using string operations?

> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:257
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None

What's up with the qmake calls?  Will this error out on systems that don't have qmake?
Comment 4 Ojan Vafai 2012-06-28 11:54:56 PDT
Comment on attachment 149968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149968&action=review

>> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:84
>> +        if port.name().startswith('chromium-'):
> 
> Should we have a way to ask the port whether it's a Chromium port rather than using string operations?

Probably. I thought about this briefly, but didn't come up with a solution I loved. I'll put a FIXME.

>> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:257
>> +MOCK run_command: ['qmake', '-v'], cwd=None
> 
> What's up with the qmake calls?  Will this error out on systems that don't have qmake?

The Qt port class calls out to qmake to find out which qt version to use. It handles failures by just choosing a specific version, so it works fine on my system that lacks qmake. This should probably be fixed, but I'm not really sure what the right fix is.
Comment 5 Ojan Vafai 2012-06-28 12:03:12 PDT
Committed r121447: <http://trac.webkit.org/changeset/121447>