Bug 90173 - Fix LayoutUnit usage in RenderImage::imageDimensionsChanged
Summary: Fix LayoutUnit usage in RenderImage::imageDimensionsChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-06-28 06:44 PDT by Dominik Röttsches (drott)
Modified: 2012-07-03 12:07 PDT (History)
6 users (show)

See Also:

Attachments
Fixing declarations. (1.60 KB, patch)
2012-06-29 03:25 PDT, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-06-28 06:44:48 PDT 
There's still two int declarations (oldwidth, oldheight) in RenderImage::imageDimensionsChanged - these should be LayoutUnit's in my understanding.
Patch follows.
Comment 1 Dominik Röttsches (drott) 2012-06-29 03:25:40 PDT 
Created attachment 150127 [details]
Fixing declarations.
Comment 2 Emil A Eklund 2012-07-03 10:50:40 PDT 
The intrinsic size for a replaced element is always in full pixels so in most cases this doesn't matter. You are right though that it should be using LayoutUnits. Thanks!
Comment 3 Eric Seidel (no email) 2012-07-03 11:40:40 PDT 
Comment on attachment 150127 [details]
Fixing declarations.

LGTM.  I don't see any way to trigger this bug.  Unless intrinsic size is somehow scaled (which I doubt).
Comment 4 Eric Seidel (no email) 2012-07-03 11:41:01 PDT 
Comment on attachment 150127 [details]
Fixing declarations.

Sorry, misclick.
Comment 5 WebKit Review Bot 2012-07-03 12:07:21 PDT 
Comment on attachment 150127 [details]
Fixing declarations.

Clearing flags on attachment: 150127

Committed r121795: <http://trac.webkit.org/changeset/121795>
Comment 6 WebKit Review Bot 2012-07-03 12:07:27 PDT 
All reviewed patches have been landed.  Closing bug.