Bug 90133 – REGRESSION(r121232): named properties on document and window may return wrong object

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Addressing Darin's comment on https://bugs.webkit.org/show_bug.cgi?id=89923:

 Comment #18 From Darin Adler 2012-06-26 11:57:21 PST (-) [reply] 
(From update of attachment 149455 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=149455&action=review

>> Source/WebCore/html/HTMLCollection.h:65
>> +    }
> 
> This looks like it could return true for a list with two items if hasLength is false, m_cache.current is 2, and itemAfter(2) is 0. Is there some reason that’s not a problem?

Sorry, let me say that again:

This looks like it could return true for a collection with two items if m_cache.hasLength is false and m_cache.current is 1. If so, there is a bug here. If not, why can’t this happen?

[Ryosuke Niwa]

Created attachment 149869 [details]
Patch

[Ryosuke Niwa]

Created attachment 149870 [details]
Patch

[WebKit Review Bot]

Comment on attachment 149870 [details]
Patch

Clearing flags on attachment: 149870

Committed r121454: <http://trac.webkit.org/changeset/121454>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.