Bug 90114 – IndexedDB: Keep direction on IDBCursor to avoid calls to back end

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joshua Bell]

IndexedDB: Keep direction on IDBCursor to avoid calls to back end

[Joshua Bell]

Created attachment 149825 [details]
Patch

[Joshua Bell]

alecflett@ - can you take a look?

I think this is the last of the simple ones. IDBTransactionBackendInterface::mode() will be difficult to remove as IDBObjectStoreBackendInterface is passed a IDBTransactionBackendInterface (for example). We'll have to solve the "XXXImpl objects deserve XXXImpl pointers" problem to clean that up.

[Joshua Bell]

alecflett@ - also, I'm not sure why IDBCursor::stringToDirection() was an unsigned int rather than an enum value. Changing it didn't seem problematic (other than having to pick a default in the error case), and was necessary for making IDBRequest::setCursorTypeAndDirection() accept the enum w/o a cast.

Speaking of, the name setCursorTypeAndDirection() is wordy. setCursorInfo() ? setCursorDetails() ?

[Alec Flett]

LGTM with extra const'ness on member variables

[Joshua Bell]

Created attachment 150218 [details]
Patch

[Joshua Bell]

(In reply to comment #4)
> LGTM with extra const'ness on member variables

Added to IDBCursor::m_direction, also (based on offline discussion) went with setCursorDetails()

[Joshua Bell]

tony@ - r?

[Tony Chang]

Comment on attachment 150218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150218&action=review

> Source/WebCore/Modules/indexeddb/IDBCursor.h:62
> +    static IDBCursor::Direction stringToDirection(const String& modeString, ExceptionCode&);

Nit: I don't think you need the IDBCursor:: prefix here.

[Joshua Bell]

(In reply to comment #8)
> > +    static IDBCursor::Direction stringToDirection(const String& modeString, ExceptionCode&);
> 
> Nit: I don't think you need the IDBCursor:: prefix here.

Apparently it is needed, otherwise it's trying to resolve WebCore::Direction - the return type part of the function declaration is outside the IDBCursor scope, or some such.

[Joshua Bell]

Created attachment 150244 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 150244 [details]
Patch for landing

Clearing flags on attachment: 150244

Committed r121612: <http://trac.webkit.org/changeset/121612>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.