RESOLVED FIXED Bug 90112
nrwt: default timeout for debug bots broke in r121363 
https://bugs.webkit.org/show_bug.cgi?id=90112
Summary nrwt: default timeout for debug bots broke in r121363
Dirk Pranke
Reported 2012-06-27 16:48:19 PDT
nrwt: default timeout for debug bots broke in r121363
Attachments
Patch (4.90 KB, patch)
2012-06-27 16:49 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-27 16:49:09 PDT
Created attachment 149820 [details] Patch
Dirk Pranke
Comment 2 2012-06-27 16:50:22 PDT
Committed r121384: <http://trac.webkit.org/changeset/121384>
Csaba Osztrogonác
Comment 3 2012-06-27 22:01:50 PDT
It broke the GTK and Qt debug bots and made 0% test coverage ... Traceback (most recent call last): File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 456, in <module> sys.exit(main()) File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 451, in main return run(port, options, args) File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 82, in run warnings = _set_up_derived_options(port, options) File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 149, in _set_up_derived_options options.slow_time_out_ms = str(5 * int(options.time_out_ms)) ValueError: invalid literal for int() with base 10: '35000.0'
Csaba Osztrogonác
Comment 4 2012-06-27 22:26:52 PDT
The following changes were rolled out to unbreak debug bots: http://trac.webkit.org/changeset/121363 http://trac.webkit.org/changeset/121367 - typo fix after r121363 http://trac.webkit.org/changeset/121384 - fix after r121363 http://trac.webkit.org/changeset/121390 - typo fix after r121390 Rollout landed in http://trac.webkit.org/changeset/121406
Simon Fraser (smfr)
Comment 5 2012-06-27 22:37:42 PDT
Broke Mac on Mountain Lion also.
Dirk Pranke
Comment 6 2012-06-28 12:55:50 PDT
closing, since the bug only manifested after r121363 and that was rolled out as well. I'll land the proper fix in bug 89706.
Note You need to log in before you can comment on or make changes to this bug.