Bug 90112 - nrwt: default timeout for debug bots broke in r121363
Summary: nrwt: default timeout for debug bots broke in r121363
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 89706
  Show dependency tree / graph
 
Reported: 2012-06-27 16:48 PDT by Dirk Pranke
Modified: 2012-06-28 12:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2012-06-27 16:49 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-06-27 16:48:19 PDT 
nrwt: default timeout for debug bots broke in r121363
Comment 1 Dirk Pranke 2012-06-27 16:49:09 PDT 
Created attachment 149820 [details]
Patch
Comment 2 Dirk Pranke 2012-06-27 16:50:22 PDT 
Committed r121384: <http://trac.webkit.org/changeset/121384>
Comment 3 Csaba Osztrogonác 2012-06-27 22:01:50 PDT 
It broke the GTK and Qt debug bots and made 0% test coverage ...

Traceback (most recent call last):
  File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 456, in <module>
    sys.exit(main())
  File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 451, in main
    return run(port, options, args)
  File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 82, in run
    warnings = _set_up_derived_options(port, options)
  File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 149, in _set_up_derived_options
    options.slow_time_out_ms = str(5 * int(options.time_out_ms))
ValueError: invalid literal for int() with base 10: '35000.0'
Comment 4 Csaba Osztrogonác 2012-06-27 22:26:52 PDT 
The following changes were rolled out to unbreak debug bots:
http://trac.webkit.org/changeset/121363
http://trac.webkit.org/changeset/121367 - typo fix after r121363
http://trac.webkit.org/changeset/121384 - fix after r121363
http://trac.webkit.org/changeset/121390  - typo fix after r121390

Rollout landed in http://trac.webkit.org/changeset/121406
Comment 5 Simon Fraser (smfr) 2012-06-27 22:37:42 PDT 
Broke Mac on Mountain Lion also.
Comment 6 Dirk Pranke 2012-06-28 12:55:50 PDT 
closing, since the bug only manifested after r121363 and that was rolled out as well. 

I'll land the proper fix in bug 89706.