Bug 90108 - [chromium] Use SkColor in compositor internals
Summary: [chromium] Use SkColor in compositor internals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 16:20 PDT by James Robinson
Modified: 2012-06-27 19:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (36.51 KB, patch)
2012-06-27 16:22 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (36.51 KB, patch)
2012-06-27 16:53 PDT, James Robinson 		enne: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-06-27 16:20:50 PDT 
[chromium] Use SkColor in compositor internals
Comment 1 James Robinson 2012-06-27 16:22:11 PDT 
Created attachment 149813 [details]
Patch
Comment 2 James Robinson 2012-06-27 16:33:28 PDT 
Comment on attachment 149813 [details]
Patch

Hmm, this passes unit / layout tests, but appears to make some things in aura render badly (i.e. the bottom tray thingy is solid black instead of transparent sometimes).  Will investigate...
Comment 3 James Robinson 2012-06-27 16:48:21 PDT 
Comment on attachment 149813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149813&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:41
> -    if (m_color.hasAlpha())
> +    if (SkColorGetA(m_color))

This is the bug with ash - hasAlpha() and SkColorGetA(color) are not the same thing - an alpha value of 0 definitely does _not_ mean the quad is opaque.
Comment 4 James Robinson 2012-06-27 16:53:26 PDT 
Created attachment 149822 [details]
Patch
Comment 5 Adrienne Walker 2012-06-27 18:15:36 PDT 
Comment on attachment 149822 [details]
Patch

R=me.
Comment 6 James Robinson 2012-06-27 19:03:35 PDT 
Committed r121396: <http://trac.webkit.org/changeset/121396>