Bug 90106 - DFG disassembly should be easier to read
Summary: DFG disassembly should be easier to read
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 15:59 PDT by Filip Pizlo
Modified: 2012-06-27 16:16 PDT (History)
0 users

See Also:

Attachments
the patch (7.98 KB, patch)
2012-06-27 16:04 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-27 15:59:29 PDT 
- Options::showDFGDisassembly doesn't show DFG OSR exits, which greatly decreases its value.

- Phi Node dumping has an automatic line wrapping thingy, which is not useful at all since most other lines in the disassembly dump are quite long.  Better let the user's text viewer do the line wrapping according to their preferences.

- DFG disassembly dump elides all skipped nodes, which has the side-effect of not showing information that is crucial for understanding OSR exits, such as SetLocal nodes and nodes which the OSR exit compiler silently interprets (UInt32ToDouble, DoubleAsInt32, etc).
Comment 1 Filip Pizlo 2012-06-27 16:04:55 PDT 
Created attachment 149812 [details]
the patch
Comment 2 Mark Hahnenberg 2012-06-27 16:14:43 PDT 
Comment on attachment 149812 [details]
the patch

r=me
Comment 3 Filip Pizlo 2012-06-27 16:16:59 PDT 
Landed in http://trac.webkit.org/changeset/121382