RESOLVED FIXED90106
DFG disassembly should be easier to read 
https://bugs.webkit.org/show_bug.cgi?id=90106
Summary DFG disassembly should be easier to read
Filip Pizlo
Reported 2012-06-27 15:59:29 PDT
- Options::showDFGDisassembly doesn't show DFG OSR exits, which greatly decreases its value. - Phi Node dumping has an automatic line wrapping thingy, which is not useful at all since most other lines in the disassembly dump are quite long. Better let the user's text viewer do the line wrapping according to their preferences. - DFG disassembly dump elides all skipped nodes, which has the side-effect of not showing information that is crucial for understanding OSR exits, such as SetLocal nodes and nodes which the OSR exit compiler silently interprets (UInt32ToDouble, DoubleAsInt32, etc).
Attachments
the patch (7.98 KB, patch)
2012-06-27 16:04 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-06-27 16:04:55 PDT
Created attachment 149812 [details] the patch
Mark Hahnenberg
Comment 2 2012-06-27 16:14:43 PDT
Comment on attachment 149812 [details] the patch r=me
Filip Pizlo
Comment 3 2012-06-27 16:16:59 PDT
Landed in http://trac.webkit.org/changeset/121382
Note You need to log in before you can comment on or make changes to this bug.