Bug 90103 - [chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and CanvasLayerTextureUpdater
Summary: [chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 15:15 PDT by Dana Jansens
Modified: 2012-06-28 09:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (23.74 KB, patch)
2012-06-27 15:23 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch for landing (23.74 KB, patch)
2012-06-28 08:05 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-06-27 15:15:12 PDT 
[chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and CanvasLayerTextureUpdater
Comment 1 Dana Jansens 2012-06-27 15:23:06 PDT 
Created attachment 149804 [details]
Patch
Comment 2 Adrienne Walker 2012-06-27 18:07:26 PDT 
Comment on attachment 149804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149804&action=review

Eep.  Nice catch!  One small nit, but otherwise R=me.

> Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:61
> +    if (contentsWidthScale != 1.0 || contentsHeightScale) {

!= 1.0 ??
Comment 3 Dana Jansens 2012-06-27 18:23:24 PDT 
Comment on attachment 149804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149804&action=review

ty :)

>> Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:61
>> +    if (contentsWidthScale != 1.0 || contentsHeightScale) {
> 
> != 1.0 ??

er.. nice catch yourself! oops!
Comment 4 Dana Jansens 2012-06-28 08:05:15 PDT 
Created attachment 149956 [details]
Patch for landing
Comment 5 Dana Jansens 2012-06-28 09:47:36 PDT 
Committed r121436: <http://trac.webkit.org/changeset/121436>