RESOLVED WORKSFORME9010
REGRESSION: Inspector tree does not render at the correct size
https://bugs.webkit.org/show_bug.cgi?id=9010
Summary REGRESSION: Inspector tree does not render at the correct size
Timothy Hatcher
Reported 2006-05-19 18:49:12 PDT
THe tree outline view does not stay contained in the top area or resize when you drag the divider.
Attachments
Picture showing the problem (76.37 KB, image/png)
2006-05-19 18:49 PDT, Timothy Hatcher
no flags
Before bug 7604 landed (r14350) (69.73 KB, image/png)
2006-05-19 19:32 PDT, Timothy Hatcher
no flags
After bug 7604 landed (r14357) (66.30 KB, image/png)
2006-05-19 19:33 PDT, Timothy Hatcher
no flags
Simple test case that shows the regression (564 bytes, text/html)
2006-05-19 19:54 PDT, Timothy Hatcher
no flags
patch (4.37 KB, patch)
2006-05-20 15:51 PDT, Sam Weinig
hyatt: review-
Timothy Hatcher
Comment 1 2006-05-19 18:49:45 PDT
Created attachment 8423 [details] Picture showing the problem
Timothy Hatcher
Comment 2 2006-05-19 19:31:47 PDT
This regression was caused by bug 7604. See the attached pictures of before and after.
Timothy Hatcher
Comment 3 2006-05-19 19:32:44 PDT
Created attachment 8424 [details] Before bug 7604 landed (r14350)
Timothy Hatcher
Comment 4 2006-05-19 19:33:31 PDT
Created attachment 8425 [details] After bug 7604 landed (r14357)
Timothy Hatcher
Comment 5 2006-05-19 19:54:52 PDT
Created attachment 8426 [details] Simple test case that shows the regression This test shows the regression. This is a regression from shipping Safari since r14350. This only happens if the element "c" (the red block) is an object, img or other replaced element. Make element c a div and it works. Element "c" specifies height of 100%, but it is a child of element "b" that has no specified height (auto). Element "a" has a height and that is the height element "c" is reflects with 100%.
Sam Weinig
Comment 6 2006-05-20 15:51:23 PDT
Created attachment 8439 [details] patch This patch does fix the issue, but I think that a more thought out fix might serve quite a bit better. I also was not able to test this in the test suite so if that reason alone it should not be landed. I would really appreciate any comments.
Dave Hyatt
Comment 7 2006-05-23 02:47:06 PDT
I don't think a new method is necessary. I'd just do it inline. I'm really curious what caused the regression though. What change broke the test?
Alice Liu
Comment 8 2006-06-06 09:42:20 PDT
Timothy Hatcher
Comment 9 2006-07-31 11:19:41 PDT
This is no longer broken, something else must have fixed this.
Note You need to log in before you can comment on or make changes to this bug.