Consider the two following x86 instructions, written out verbosely: 1) load from address 0x12345 into register RAX 2) move immediate 0x12345 into register RAX In AT&T syntax, the two should be written thus: 1) mov 0x12345, %rax 2) mov $0x12345, %rax But our x86 disassembler (udis86) incorrectly writes both as "mov 0x12345, %rax". In short, it omits the "$" prefix for immediates.
Created attachment 149797 [details] the patch
Attachment 149797 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:112: Extra space after ( in function call [whitespace/parens] [4] Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:112: Extra space before ) [whitespace/parens] [2] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 149797 [details] the patch r=me
Landed in http://trac.webkit.org/changeset/121374