WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
90093
REGRESSION(
r121113
): Safari 5.1.x hangs on keyboard-initiated application quit with ToT WebKit.
https://bugs.webkit.org/show_bug.cgi?id=90093
Summary
REGRESSION(r121113): Safari 5.1.x hangs on keyboard-initiated application qui...
Ryosuke Niwa
Reported
2012-06-27 12:39:12 PDT
When ToT builds of WebKit is used with Safari Version 5.1.7 on Snow Leopard, WebKit never quits. It seems like WebProcess is completely hung and "Quit" on File menu is grayed out.
Attachments
Safari sample
(69.31 KB, text/plain)
2012-06-29 00:33 PDT
,
Andreas Kling
no flags
Details
WebProcess sample
(59.41 KB, text/plain)
2012-06-29 00:33 PDT
,
Andreas Kling
no flags
Details
Hackish patch
(3.99 KB, patch)
2012-06-29 04:31 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2012-06-28 22:08:55 PDT
A sample of the Web Process would be useful.
Alexey Proskuryakov
Comment 2
2012-06-29 00:11:06 PDT
***
Bug 90131
has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 3
2012-06-29 00:11:13 PDT
***
Bug 90137
has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 4
2012-06-29 00:11:35 PDT
***
Bug 90220
has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 5
2012-06-29 00:12:40 PDT
From duplicates, it's not just on Snow Leopard.
Mark Rowe (bdash)
Comment 6
2012-06-29 00:24:06 PDT
I think Andreas introduced this in
r121113
.
Andreas Kling
Comment 7
2012-06-29 00:33:00 PDT
Created
attachment 150101
[details]
Safari sample
Andreas Kling
Comment 8
2012-06-29 00:33:16 PDT
Created
attachment 150102
[details]
WebProcess sample
Andreas Kling
Comment 9
2012-06-29 04:23:53 PDT
The problem is that [WKView _doneWithKeyEvent] triggers a nested event loop which never returns and thus prevents the synchronous response to WebPageProxy::DidReceiveKeyEvent from ever getting delivered back to the WebProcess. Thus the WebProcess is stuck waiting for that sync response, and the UIProcess is stuck waiting for the WebProcess to die off. Boom, deadlock.
Andreas Kling
Comment 10
2012-06-29 04:31:58 PDT
Created
attachment 150137
[details]
Hackish patch
Jim Oase
Comment 11
2012-06-30 15:52:48 PDT
Version 5.1.7 (7534.57.2,
r121628
) Patch does fix the problem on my MacBook. Still hangs on quit.
Andreas Kling
Comment 12
2012-07-02 02:32:22 PDT
Rolled out the offending changes in <
http://trac.webkit.org/changeset/121665
>.
Alexey Proskuryakov
Comment 13
2012-07-04 13:10:42 PDT
***
Bug 90397
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug