RESOLVED FIXED Bug 90090
build-webkit should verify that your tools are up-to-date 
https://bugs.webkit.org/show_bug.cgi?id=90090
Summary build-webkit should verify that your tools are up-to-date
Simon Fraser (smfr)
Reported 2012-06-27 11:47:02 PDT
The build scripts should check that your tools (Xcode and compiler versions) are up-to-date, and, if not, print out an error and refuse to build (with a pointer to how to update the tools). Otherwise we have people trying to build with Xcode 3 and getting mysterious failures.
Attachments
patch (3.53 KB, patch)
2012-09-26 16:17 PDT, Enrica Casucci 		mrowe: review-
DetailsFormatted DiffDiff
Patch v1 (6.93 KB, patch)
2013-09-20 12:35 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-06-27 11:51:00 PDT
(In reply to comment #0) > The build scripts should check that your tools (Xcode and compiler versions) are up-to-date, and, if not, print out an error and refuse to build (with a pointer to how to update the tools). That’s what checkRequiredSystemConfig() in webkitdirs.pm does.
Mark Rowe (bdash)
Comment 2 2012-06-27 11:54:54 PDT
What does "up-to-date" mean in this context?
Lucas Forschler
Comment 3 2012-06-27 12:00:16 PDT
checkRequiredSystemConfig checks for: MacOS 10.4 or newer Xcode 2.3 or newer
Simon Fraser (smfr)
Comment 4 2012-06-27 12:01:51 PDT
"up-to-date' means "know to successfully build the requested configuration. Preferably at or more recent that the oldest supported Xcode/compiler version.
Mark Rowe (bdash)
Comment 5 2012-06-27 12:16:39 PDT
Any version of Xcode 3 or greater knows how to build WebKit. The issue is simply that in some less commonly used configurations (e.g., with non-default arguments to build-webkit) the code generates extra warnings that break the build when GCC or LLVM GCC is used. We'd have to impose a minimum Xcode version of 4.2 in order to never use those compilers when building.
Simon Fraser (smfr)
Comment 6 2012-06-27 12:46:03 PDT
Then I think we should require Xcode 4.2.
Radar WebKit Bug Importer
Comment 7 2012-09-24 13:44:05 PDT
<rdar://problem/12361387>
Mark Rowe (bdash)
Comment 8 2012-09-26 16:11:25 PDT
*** Bug 97737 has been marked as a duplicate of this bug. ***
Enrica Casucci
Comment 9 2012-09-26 16:17:34 PDT
Created attachment 165892 [details] patch
Eric Seidel (no email)
Comment 10 2013-01-04 00:52:57 PST
Attachment 165892 [details] was posted by a committer and has review+, assigning to Enrica Casucci for commit.
Mark Rowe (bdash)
Comment 11 2013-09-20 12:02:29 PDT
Comment on attachment 165892 [details] patch Marking as r- since this is now very out of date.
Mark Rowe (bdash)
Comment 12 2013-09-20 12:35:17 PDT
Created attachment 212206 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 13 2013-09-20 15:33:41 PDT
Comment on attachment 212206 [details] Patch v1 r=me
WebKit Commit Bot
Comment 14 2013-09-20 16:00:32 PDT
Comment on attachment 212206 [details] Patch v1 Clearing flags on attachment: 212206 Committed r156208: <http://trac.webkit.org/changeset/156208>
WebKit Commit Bot
Comment 15 2013-09-20 16:00:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.